From c0a188703aa8ae849998dcfec016dd1d64d32107 Mon Sep 17 00:00:00 2001 From: Stas Vilchik Date: Wed, 15 Apr 2015 17:57:45 +0200 Subject: [PATCH] SONAR-6423 The rule modal opens twice when show/hide/show an issue in the component viewer --- .../sonar-web/src/main/js/source-viewer/viewer.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/server/sonar-web/src/main/js/source-viewer/viewer.js b/server/sonar-web/src/main/js/source-viewer/viewer.js index 82699e17791..8b92da692a1 100644 --- a/server/sonar-web/src/main/js/source-viewer/viewer.js +++ b/server/sonar-web/src/main/js/source-viewer/viewer.js @@ -457,11 +457,17 @@ define([ }, onLineIssuesClick: function (e) { - var line = $(e.currentTarget).data('line-number'); - if ($(e.currentTarget).parent().find('.issue-list').is('.hidden')) { - this.showIssuesForLine(line); + var line = $(e.currentTarget).data('line-number'), + issuesList = $(e.currentTarget).parent().find('.issue-list'), + areIssuesRendered = issuesList.find('.issue-inner').length > 0; + if (issuesList.is('.hidden')) { + if (areIssuesRendered) { + issuesList.removeClass('hidden'); + } else { + this.showIssuesForLine(line); + } } else { - $(e.currentTarget).parent().find('.issue-list').addClass('hidden'); + issuesList.addClass('hidden'); } }, -- 2.39.5