From c0ed526d8784de6312cb9434b86390a3c1b593bf Mon Sep 17 00:00:00 2001 From: aclement Date: Fri, 13 Nov 2009 17:40:59 +0000 Subject: [PATCH] tag for possible optimization --- .../src/org/aspectj/apache/bcel/classfile/Attribute.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bcel-builder/src/org/aspectj/apache/bcel/classfile/Attribute.java b/bcel-builder/src/org/aspectj/apache/bcel/classfile/Attribute.java index aefa0ed44..f10150de0 100644 --- a/bcel-builder/src/org/aspectj/apache/bcel/classfile/Attribute.java +++ b/bcel-builder/src/org/aspectj/apache/bcel/classfile/Attribute.java @@ -70,7 +70,7 @@ import org.aspectj.apache.bcel.classfile.annotation.RuntimeVisParamAnnos; * Exceptiontable, LineNumberTable, LocalVariableTable, InnerClasses and Synthetic * attributes are supported. The Unknown attribute stands for non-standard-attributes. * - * @version $Id: Attribute.java,v 1.7 2009/09/15 19:40:12 aclement Exp $ + * @version $Id: Attribute.java,v 1.8 2009/11/13 17:40:59 aclement Exp $ * @author M. Dahm * @see ConstantValue * @see SourceFile @@ -104,6 +104,7 @@ public abstract class Attribute implements Cloneable, Node, Serializable { file.writeInt(length); } + // OPTIMIZE how about just reading them in and storing them until we need to decode what they really are? public static final Attribute readAttribute(DataInputStream file, ConstantPool cpool) throws IOException { byte tag = Constants.ATTR_UNKNOWN; int idx = file.readUnsignedShort(); -- 2.39.5