From c1672e6738167fb97184cfe0117d296263ff5eba Mon Sep 17 00:00:00 2001
From: Julien Lancelot <julien.lancelot@gmail.com>
Date: Mon, 1 Jul 2013 09:58:35 +0200
Subject: [PATCH] Remove fetchSize in issues SQL and reactivate previously
 deactivated unit test

---
 .../org/sonar/core/issue/db/IssueMapper.xml   | 77 +++++--------------
 .../sonar/core/issue/db/IssueStatsMapper.xml  |  2 +-
 2 files changed, 22 insertions(+), 57 deletions(-)

diff --git a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
index 3f1d11dd81b..f407ec3289a 100644
--- a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
+++ b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueMapper.xml
@@ -201,72 +201,37 @@
     </where>
   </select>
 
-  <select id="selectIssues" parameterType="map" resultType="Issue" fetchSize="100000">
-    select
-    <choose>
-      <when test="returnOnlyIdAndSortColumns == true">
-        i.id
-        <include refid="sortColumn"/>
-        from issues i
-      </when>
-      <otherwise>
-        <include refid="issueColumns"/>
-        from issues i
-        inner join rules r on r.id=i.rule_id
-        inner join projects p on p.id=i.component_id
-        inner join projects root on root.id=i.root_component_id
-      </otherwise>
-    </choose>
+  <select id="selectIssues" parameterType="map" resultType="Issue">
+    select <include refid="issueColumns"/>
+    from issues i
+    inner join rules r on r.id=i.rule_id
+    inner join projects p on p.id=i.component_id
+    inner join projects root on root.id=i.root_component_id
     <include refid="selectQueryConditions"/>
-    <if test="maxResults != null">
-      limit #{maxResults}
-    </if>
+  </select>
+
+  <select id="selectIssueIds" parameterType="map" resultType="Issue">
+    select i.id <include refid="sortColumn"/>
+    from issues i
+    <include refid="selectQueryConditions"/>
+    limit #{maxResults}
   </select>
 
   <!-- SQL Server -->
-  <select id="selectIssues" parameterType="map" resultType="Issue" fetchSize="100000" databaseId="mssql">
-    select
-    <if test="maxResults != null">
-      top (#{maxResults})
-    </if>
-    <choose>
-      <when test="returnOnlyIdAndSortColumns == true">
-        i.id
-        <include refid="sortColumn"/>
-        from issues i
-      </when>
-      <otherwise>
-        <include refid="issueColumns"/>
-        from issues i
-        inner join rules r on r.id=i.rule_id
-        inner join projects p on p.id=i.component_id
-        inner join projects root on root.id=i.root_component_id
-      </otherwise>
-    </choose>
+  <select id="selectIssueIds" parameterType="map" resultType="Issue" databaseId="mssql">
+    select top (#{maxResults}) i.id <include refid="sortColumn"/>
+    from issues i
     <include refid="selectQueryConditions"/>
   </select>
 
   <!-- Oracle -->
-  <select id="selectIssues" parameterType="map" resultType="Issue" fetchSize="100000" databaseId="oracle">
+  <select id="selectIssueIds" parameterType="map" resultType="Issue" databaseId="oracle">
     select * from (select
-    <choose>
-      <when test="returnOnlyIdAndSortColumns == true">
-        i.id
-        <include refid="sortColumn"/>
-      </when>
-      <otherwise>
-        <include refid="issueColumns"/>
-        from issues i
-        inner join rules r on r.id=i.rule_id
-        inner join projects p on p.id=i.component_id
-        inner join projects root on root.id=i.root_component_id
-      </otherwise>
-    </choose>
-    <include refid="selectQueryConditions"/>
+      i.id <include refid="sortColumn"/>
+      from issues i
+      <include refid="selectQueryConditions"/>
     )
-    <if test="maxResults != null">
-      where rownum &lt;= #{maxResults}
-    </if>
+    where rownum &lt;= #{maxResults}
   </select>
 
   <sql id="selectQueryConditions">
diff --git a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueStatsMapper.xml b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueStatsMapper.xml
index accae5e1b88..5369af45148 100644
--- a/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueStatsMapper.xml
+++ b/sonar-core/src/main/resources/org/sonar/core/issue/db/IssueStatsMapper.xml
@@ -4,7 +4,7 @@
 
 <mapper namespace="org.sonar.core.issue.db.IssueStatsMapper">
 
-  <select id="selectIssuesColumn" parameterType="map" resultType="Object" fetchSize="100000">
+  <select id="selectIssuesColumn" parameterType="map" resultType="Object">
     select
     <if test="'ASSIGNEE'.equals(column)">
       i.assignee
-- 
2.39.5