From c29138311614cba8bc4699a0afa485aefe621b6b Mon Sep 17 00:00:00 2001 From: Robin McCorkell Date: Fri, 9 Jan 2015 13:13:02 +0000 Subject: [PATCH] Memcache binary executable searching It's slow, this makes it fast! --- lib/private/helper.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/private/helper.php b/lib/private/helper.php index 8e9b7d3b6f3..86cc0850bc3 100644 --- a/lib/private/helper.php +++ b/lib/private/helper.php @@ -882,13 +882,19 @@ class OC_Helper { * @return null|string */ public static function findBinaryPath($program) { + $memcache = \OC::$server->getMemCacheFactory()->create('findBinaryPath'); + if ($memcache->hasKey($program)) { + return $memcache->get($program); + } + $result = null; if (!\OC_Util::runningOnWindows() && self::is_function_enabled('exec')) { exec('command -v ' . escapeshellarg($program) . ' 2> /dev/null', $output, $returnCode); if ($returnCode === 0 && count($output) > 0) { - return escapeshellcmd($output[0]); + $result = escapeshellcmd($output[0]); } } - return null; + $memcache->set($program, $result, 3600); + return $result; } /** -- 2.39.5