From c4ed3c9afdb480910a40fe7e01c35cc853e4a1b8 Mon Sep 17 00:00:00 2001 From: Jouni Koivuviita Date: Mon, 27 Oct 2008 11:46:21 +0000 Subject: [PATCH] Fixes #2152: Embedded: document.onunload and document.onbeforeunload do not fire in IE6/7 when inside CustomLayout A clear bug in ICustomLayout: overriding onDetach()-method did not call super.onDetach(). This fix is for the 5.3 branch. svn changeset:5733/svn branch:trunk --- .../itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java index 09987f2b73..6e65d9613c 100644 --- a/src/com/itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java +++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/ICustomLayout.java @@ -383,6 +383,7 @@ public class ICustomLayout extends ComplexPanel implements Paintable, } /** Removes given widget from the layout */ + @Override public boolean remove(Widget w) { client.unregisterPaintable((Paintable) w); final String location = getLocation(w); @@ -401,11 +402,13 @@ public class ICustomLayout extends ComplexPanel implements Paintable, } /** Adding widget without specifying location is not supported */ + @Override public void add(Widget w) { throw new UnsupportedOperationException(); } /** Clear all widgets from the layout */ + @Override public void clear() { super.clear(); locationToWidget.clear(); @@ -427,7 +430,9 @@ public class ICustomLayout extends ComplexPanel implements Paintable, client.runDescendentsLayout(this); } + @Override public void onDetach() { + super.onDetach(); detachResizedFunction(DOM.getFirstChild(getElement())); } -- 2.39.5