From c6106543e1c54f7a776a77140717ef6fbd924233 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Sun, 29 Jul 2012 10:12:26 +0000 Subject: [PATCH] html5 compliance. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10110 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/helpers/issues_helper.rb | 2 +- app/views/attachments/_form.html.erb | 2 +- test/unit/helpers/issues_helper_test.rb | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index ece3f7844..1ba4c4635 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -290,7 +290,7 @@ module IssuesHelper unless no_html label = content_tag('strong', label) old_value = content_tag("i", h(old_value)) if detail.old_value - old_value = content_tag("strike", old_value) if detail.old_value and detail.value.blank? + old_value = content_tag("del", old_value) if detail.old_value and detail.value.blank? if detail.property == 'attachment' && !value.blank? && atta = Attachment.find_by_id(detail.prop_key) # Link to the attachment if it has not been removed value = link_to_attachment(atta, :download => true, :only_path => options[:only_path]) diff --git a/app/views/attachments/_form.html.erb b/app/views/attachments/_form.html.erb index dd55fa3f1..e47c288a9 100644 --- a/app/views/attachments/_form.html.erb +++ b/app/views/attachments/_form.html.erb @@ -8,7 +8,7 @@ <% end %> - <%= file_field_tag 'attachments[1][file]', :size => 30, :id => nil, :class => 'file', + <%= file_field_tag 'attachments[1][file]', :id => nil, :class => 'file', :onchange => "checkFileSize(this, #{Setting.attachment_max_size.to_i.kilobytes}, '#{escape_javascript(l(:error_attachment_too_big, :max_size => number_to_human_size(Setting.attachment_max_size.to_i.kilobytes)))}');" -%> <%= text_field_tag 'attachments[1][description]', '', :id => nil, :class => 'description', :maxlength => 255, :placeholder => l(:label_optional_description) %> <%= link_to_function(image_tag('delete.png'), 'removeFileField(this)', :title => (l(:button_delete))) %> diff --git a/test/unit/helpers/issues_helper_test.rb b/test/unit/helpers/issues_helper_test.rb index ab81f5a52..91c6f5a4e 100644 --- a/test/unit/helpers/issues_helper_test.rb +++ b/test/unit/helpers/issues_helper_test.rb @@ -32,7 +32,8 @@ class IssuesHelperTest < ActionView::TestCase :enabled_modules, :workflows, :custom_fields, - :attachments + :attachments, + :versions def setup super @@ -104,7 +105,7 @@ class IssuesHelperTest < ActionView::TestCase html = show_detail(@detail, false) assert_include '% Done', html - assert_include '50', html + assert_include '50', html end end -- 2.39.5