From c81f853fd949d0e515459733b5f5a867b9e2ee0f Mon Sep 17 00:00:00 2001 From: Teemu Suo-Anttila Date: Tue, 18 Jul 2017 14:31:10 +0300 Subject: [PATCH] Fix TreeGrid.getHierarchyColumn to use correct id (#9690) Fixes #9661 --- server/src/main/java/com/vaadin/ui/TreeGrid.java | 2 +- .../tests/components/treegrid/TreeGridTest.java | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/server/src/main/java/com/vaadin/ui/TreeGrid.java b/server/src/main/java/com/vaadin/ui/TreeGrid.java index 703a83192a..8ee154a56e 100644 --- a/server/src/main/java/com/vaadin/ui/TreeGrid.java +++ b/server/src/main/java/com/vaadin/ui/TreeGrid.java @@ -248,7 +248,7 @@ public class TreeGrid extends Grid * has been explicitly set */ public Column getHierarchyColumn() { - return getColumn(getState(false).hierarchyColumnId); + return getColumnByInternalId(getState(false).hierarchyColumnId); } /** diff --git a/server/src/test/java/com/vaadin/tests/components/treegrid/TreeGridTest.java b/server/src/test/java/com/vaadin/tests/components/treegrid/TreeGridTest.java index fdaacae48b..1876d8de35 100644 --- a/server/src/test/java/com/vaadin/tests/components/treegrid/TreeGridTest.java +++ b/server/src/test/java/com/vaadin/tests/components/treegrid/TreeGridTest.java @@ -5,6 +5,7 @@ import org.junit.Test; import com.vaadin.data.TreeData; import com.vaadin.data.provider.TreeDataProvider; +import com.vaadin.ui.Grid.Column; import com.vaadin.ui.TreeGrid; import com.vaadin.ui.renderers.TextRenderer; @@ -14,6 +15,7 @@ public class TreeGridTest { private boolean expandEventFired = false; private boolean collapseEventFired = false; + @Test public void testChangeRendererOfHierarchyColumn() { treeGrid.addColumn(Object::toString).setId("foo"); treeGrid.setHierarchyColumn("foo"); @@ -44,4 +46,14 @@ public class TreeGridTest { Assert.assertFalse("Item not collapsed", treeGrid.isExpanded("Foo")); Assert.assertTrue("Collapse event not fired", collapseEventFired); } + + @Test + public void testSetAndGetHierarchyColumn() { + Column column = treeGrid.addColumn(Object::toString) + .setId("foo"); + treeGrid.setHierarchyColumn("foo"); + Assert.assertEquals("Hierarchy column was not correctly returned", + column, treeGrid.getHierarchyColumn()); + } + } -- 2.39.5