From c92f4253097fa846f32e3a9193692b74af6ba7b8 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Wed, 8 Jan 2014 06:03:54 +0000 Subject: [PATCH] Rails4: replace deprecated Relation#update_all at IssuesControllerTest git-svn-id: http://svn.redmine.org/redmine/trunk@12519 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- test/functional/issues_controller_test.rb | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/functional/issues_controller_test.rb b/test/functional/issues_controller_test.rb index 9fe0b2dca..4945ad58f 100644 --- a/test/functional/issues_controller_test.rb +++ b/test/functional/issues_controller_test.rb @@ -1026,7 +1026,7 @@ class IssuesControllerTest < ActionController::TestCase end def test_show_should_deny_anonymous_access_to_private_issue - Issue.update_all(["is_private = ?", true], "id = 1") + Issue.where(:id => 1).update_all(["is_private = ?", true]) get :show, :id => 1 assert_response :redirect end @@ -1039,7 +1039,7 @@ class IssuesControllerTest < ActionController::TestCase end def test_show_should_deny_non_member_access_to_private_issue - Issue.update_all(["is_private = ?", true], "id = 1") + Issue.where(:id => 1).update_all(["is_private = ?", true]) @request.session[:user_id] = 9 get :show, :id => 1 assert_response 403 @@ -1053,28 +1053,28 @@ class IssuesControllerTest < ActionController::TestCase end def test_show_should_deny_member_access_to_private_issue_without_permission - Issue.update_all(["is_private = ?", true], "id = 1") + Issue.where(:id => 1).update_all(["is_private = ?", true]) @request.session[:user_id] = 3 get :show, :id => 1 assert_response 403 end def test_show_should_allow_author_access_to_private_issue - Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1") + Issue.where(:id => 1).update_all(["is_private = ?, author_id = 3", true]) @request.session[:user_id] = 3 get :show, :id => 1 assert_response :success end def test_show_should_allow_assignee_access_to_private_issue - Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1") + Issue.where(:id => 1).update_all(["is_private = ?, assigned_to_id = 3", true]) @request.session[:user_id] = 3 get :show, :id => 1 assert_response :success end def test_show_should_allow_member_access_to_private_issue_with_permission - Issue.update_all(["is_private = ?", true], "id = 1") + Issue.where(:id => 1).update_all(["is_private = ?", true]) User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all' @request.session[:user_id] = 3 get :show, :id => 1 -- 2.39.5