From c95776464e57b73d6c5dacbb6a32b346080cb831 Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Wed, 2 Mar 2016 09:37:01 +0100
Subject: [PATCH] SONAR-7329 display rule type in description

---
 .../coding-rules/templates/rule/coding-rules-rule-meta.hbs   | 5 +++++
 .../js/components/workspace/templates/workspace-rule.hbs     | 5 +++++
 server/sonar-web/src/main/less/pages/coding-rules.less       | 2 +-
 sonar-core/src/main/resources/org/sonar/l10n/core.properties | 3 +++
 4 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/server/sonar-web/src/main/js/apps/coding-rules/templates/rule/coding-rules-rule-meta.hbs b/server/sonar-web/src/main/js/apps/coding-rules/templates/rule/coding-rules-rule-meta.hbs
index 2ca76e8c95d..1b225182a0d 100644
--- a/server/sonar-web/src/main/js/apps/coding-rules/templates/rule/coding-rules-rule-meta.hbs
+++ b/server/sonar-web/src/main/js/apps/coding-rules/templates/rule/coding-rules-rule-meta.hbs
@@ -16,6 +16,11 @@
 
 <ul class="coding-rules-detail-properties">
   {{#unless isManual}}
+    <li class="coding-rules-detail-property"
+        data-toggle="tooltip" data-placement="bottom" title="{{t 'coding_rules.type.tooltip' this.type}}">
+      {{issueType this.type}}
+    </li>
+
     <li class="coding-rules-detail-property"
         data-toggle="tooltip" data-placement="bottom" title="Default rule severity">
       {{severityIcon severity}}&nbsp;{{t "severity" severity}}
diff --git a/server/sonar-web/src/main/js/components/workspace/templates/workspace-rule.hbs b/server/sonar-web/src/main/js/components/workspace/templates/workspace-rule.hbs
index 40a1c3ff74b..1618f444b62 100644
--- a/server/sonar-web/src/main/js/components/workspace/templates/workspace-rule.hbs
+++ b/server/sonar-web/src/main/js/components/workspace/templates/workspace-rule.hbs
@@ -7,6 +7,11 @@
     <ul class="coding-rules-detail-properties">
       {{#if severity}}
         {{#unless isManual}}
+          <li class="coding-rules-detail-property"
+              data-toggle="tooltip" data-placement="bottom" title="{{t 'coding_rules.type.tooltip' this.type}}">
+            {{issueType this.type}}
+          </li>
+
           <li class="coding-rules-detail-property"
               data-toggle="tooltip" data-placement="bottom" title="Default rule severity">
             {{severityIcon severity}}&nbsp;{{t "severity" severity}}
diff --git a/server/sonar-web/src/main/less/pages/coding-rules.less b/server/sonar-web/src/main/less/pages/coding-rules.less
index 83d7aad6231..2e1015b2fc4 100644
--- a/server/sonar-web/src/main/less/pages/coding-rules.less
+++ b/server/sonar-web/src/main/less/pages/coding-rules.less
@@ -192,7 +192,7 @@
   margin-right: 2 * @navigatorPadding;
   font-size: @smallFontSize;
   height: 22px;
-  line-height: 22px;
+  line-height: 18px;
 
   .select2-search-field { line-height: 1; }
 }
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 562b3c9026f..75bb6f83cb3 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -1959,6 +1959,9 @@ coding_rules.rule_template.title=This rule can be used as a template to create c
 coding_rules._rules=rules
 coding_rules.select_tag=Select Tag
 coding_rules.show_template=Show Template
+coding_rules.type.tooltip.CODE_SMELL=Code Smell Detection Rule
+coding_rules.type.tooltip.BUG=Bug Detection Rule
+coding_rules.type.tooltip.VULNERABILITY=Vulnerability Detection Rule
 coding_rules.noncharacterized=Uncharacterized
 coding_rules.update_custom_rule=Update Custom Rule
 coding_rules.update_manual_rule=Update Manual Rule
-- 
2.39.5