From cc54a81b16f81db55b1a9899fcd533f1c419a62b Mon Sep 17 00:00:00 2001 From: Simon L Date: Thu, 12 Jan 2023 23:02:59 +0100 Subject: [PATCH] address review Signed-off-by: Simon L --- apps/user_ldap/lib/Access.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/user_ldap/lib/Access.php b/apps/user_ldap/lib/Access.php index 45ab3c42399..1cc0c62ff1d 100644 --- a/apps/user_ldap/lib/Access.php +++ b/apps/user_ldap/lib/Access.php @@ -1369,8 +1369,11 @@ class Access extends LDAPUtility { // Remove unknown leftover entities $name = preg_replace('#&[^;]+;#', '', $name); + // Replacements + $name = str_replace(' ', '_', $name); + // Every remaining disallowed characters will be removed - $name = preg_replace('/[^a-zA-Z0-9 _.@-]/u', '', $name); + $name = preg_replace('/[^a-zA-Z0-9_.@-]/u', '', $name); if (strlen($name) > 64) { $name = hash('sha256', $name, false); -- 2.39.5