From d241928142bfb2d83cc748876936af044cda9241 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Thu, 30 Apr 2015 10:27:27 +0200 Subject: [PATCH] Fix some other quality flaws --- .../sonar/plugins/emailnotifications/AlertsEmailTemplate.java | 2 +- .../src/main/java/org/sonar/server/startup/LogServerId.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/sonar-email-notifications-plugin/src/main/java/org/sonar/plugins/emailnotifications/AlertsEmailTemplate.java b/plugins/sonar-email-notifications-plugin/src/main/java/org/sonar/plugins/emailnotifications/AlertsEmailTemplate.java index 542d35204f4..a66444ad838 100644 --- a/plugins/sonar-email-notifications-plugin/src/main/java/org/sonar/plugins/emailnotifications/AlertsEmailTemplate.java +++ b/plugins/sonar-email-notifications-plugin/src/main/java/org/sonar/plugins/emailnotifications/AlertsEmailTemplate.java @@ -52,7 +52,7 @@ public class AlertsEmailTemplate extends EmailTemplate { String alertName = notification.getFieldValue("alertName"); String alertText = notification.getFieldValue("alertText"); String alertLevel = notification.getFieldValue("alertLevel"); - boolean isNewAlert = Boolean.valueOf(notification.getFieldValue("isNewAlert")); + boolean isNewAlert = Boolean.parseBoolean(notification.getFieldValue("isNewAlert")); // Generate text String subject = generateSubject(projectName, alertLevel, isNewAlert); diff --git a/server/sonar-server/src/main/java/org/sonar/server/startup/LogServerId.java b/server/sonar-server/src/main/java/org/sonar/server/startup/LogServerId.java index cf6ea5dd47d..5fcbeb02a3e 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/startup/LogServerId.java +++ b/server/sonar-server/src/main/java/org/sonar/server/startup/LogServerId.java @@ -42,7 +42,7 @@ public final class LogServerId { } @VisibleForTesting - protected void logServerId(Logger logger) { + void logServerId(Logger logger) { PropertyDto serverIdProp = propertiesDao.selectGlobalProperty(CoreProperties.PERMANENT_SERVER_ID); if (serverIdProp != null) { // a server ID has been generated, let's print out the other useful informations that can help debugging license issues -- 2.39.5