From d6052456d0555a6a8c7b4d7335f9ba7622fdd5a3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gr=C3=A9goire=20Aubert?= Date: Tue, 31 Jul 2018 11:40:51 +0200 Subject: [PATCH] SONAR-11037 Update icons for alm repository items in the project creationg page --- .../js/apps/projects/create/AlmRepositoryItem.tsx | 9 +++++---- .../__snapshots__/AlmRepositoryItem-test.tsx.snap | 13 +++++++------ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/server/sonar-web/src/main/js/apps/projects/create/AlmRepositoryItem.tsx b/server/sonar-web/src/main/js/apps/projects/create/AlmRepositoryItem.tsx index 8e21b7111ae..e01c79c32dc 100644 --- a/server/sonar-web/src/main/js/apps/projects/create/AlmRepositoryItem.tsx +++ b/server/sonar-web/src/main/js/apps/projects/create/AlmRepositoryItem.tsx @@ -18,11 +18,12 @@ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ import * as React from 'react'; +import * as theme from '../../../app/theme'; import Checkbox from '../../../components/controls/Checkbox'; +import CheckIcon from '../../../components/icons-components/CheckIcon'; import { AlmRepository, IdentityProvider } from '../../../app/types'; import { getBaseUrl } from '../../../helpers/urls'; import { translate } from '../../../helpers/l10n'; -import CheckIcon from '../../../components/icons-components/CheckIcon'; interface Props { identityProvider: IdentityProvider; @@ -48,14 +49,14 @@ export default class AlmRepositoryItem extends React.PureComponent { alt={identityProvider.name} className="spacer-left" height={14} - src={getBaseUrl() + identityProvider.iconPath} - style={{ filter: alreadyImported ? 'invert(50%)' : 'invert(100%)' }} + src={`${getBaseUrl()}/images/sonarcloud/${identityProvider.key}.svg`} + style={{ opacity: alreadyImported ? 0.5 : 1 }} width={14} /> {this.props.repository.label} {alreadyImported && ( - + {translate('onboarding.create_project.already_imported')} )} diff --git a/server/sonar-web/src/main/js/apps/projects/create/__tests__/__snapshots__/AlmRepositoryItem-test.tsx.snap b/server/sonar-web/src/main/js/apps/projects/create/__tests__/__snapshots__/AlmRepositoryItem-test.tsx.snap index ad71bfc6e60..eddcbf0214b 100644 --- a/server/sonar-web/src/main/js/apps/projects/create/__tests__/__snapshots__/AlmRepositoryItem-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/projects/create/__tests__/__snapshots__/AlmRepositoryItem-test.tsx.snap @@ -11,10 +11,10 @@ exports[`should render correctly 1`] = ` alt="Foo Provider" className="spacer-left" height={14} - src="icon/path" + src="/images/sonarcloud/foo.svg" style={ Object { - "filter": "invert(100%)", + "opacity": 1, } } width={14} @@ -38,10 +38,10 @@ exports[`should render disabled 1`] = ` alt="Foo Provider" className="spacer-left" height={14} - src="icon/path" + src="/images/sonarcloud/foo.svg" style={ Object { - "filter": "invert(50%)", + "opacity": 0.5, } } width={14} @@ -56,6 +56,7 @@ exports[`should render disabled 1`] = ` > onboarding.create_project.already_imported @@ -73,10 +74,10 @@ exports[`should render selected 1`] = ` alt="Foo Provider" className="spacer-left" height={14} - src="icon/path" + src="/images/sonarcloud/foo.svg" style={ Object { - "filter": "invert(100%)", + "opacity": 1, } } width={14} -- 2.39.5