From db4cc01001f1cb57bb550a20307f24e43dadcd39 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Fri, 12 Apr 2013 17:27:11 +0200 Subject: [PATCH] SONAR-3755 minor comments --- .../org/sonar/core/issue/DefaultIssueFinder.java | 1 - .../src/main/java/org/sonar/core/issue/IssueDao.java | 2 ++ .../main/java/org/sonar/api/issue/JRubyIssues.java | 12 ++++++++++-- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/sonar-core/src/main/java/org/sonar/core/issue/DefaultIssueFinder.java b/sonar-core/src/main/java/org/sonar/core/issue/DefaultIssueFinder.java index 0e6c8f83b5c..3689c541f60 100644 --- a/sonar-core/src/main/java/org/sonar/core/issue/DefaultIssueFinder.java +++ b/sonar-core/src/main/java/org/sonar/core/issue/DefaultIssueFinder.java @@ -93,7 +93,6 @@ public class DefaultIssueFinder implements IssueFinder { } })); - return new DefaultResults(issues); } diff --git a/sonar-core/src/main/java/org/sonar/core/issue/IssueDao.java b/sonar-core/src/main/java/org/sonar/core/issue/IssueDao.java index 8514ce2f75e..2962518a8c4 100644 --- a/sonar-core/src/main/java/org/sonar/core/issue/IssueDao.java +++ b/sonar-core/src/main/java/org/sonar/core/issue/IssueDao.java @@ -88,6 +88,8 @@ public class IssueDao implements BatchComponent, ServerComponent { public List select(IssueQuery query) { SqlSession session = mybatis.openSession(); try { + // TODO support ordering + return session.selectList("org.sonar.core.issue.IssueMapper.select", query, new RowBounds(query.offset(), query.limit())); } finally { diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/issue/JRubyIssues.java b/sonar-plugin-api/src/main/java/org/sonar/api/issue/JRubyIssues.java index 8ed376ab670..3cb966e800a 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/issue/JRubyIssues.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/issue/JRubyIssues.java @@ -28,14 +28,22 @@ import java.util.Map; *

* Reference from Ruby code : Api.issues *

+ * + * @since 3.6 */ public interface JRubyIssues extends ServerComponent { /** - * Api.issues.find(hash) + * Search for issues. * - * TODO document parameters + *

+ * Ruby: Api.issues.find(hash) + *

* + *

Parameters

+ * */ IssueFinder.Results find(Map parameters); -- 2.39.5