From db973cfed7c7d63f8703171335e61bc6eb4f297a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gr=C3=A9goire=20Aubert?= Date: Fri, 24 May 2024 15:59:34 +0200 Subject: [PATCH] SONAR-22218 Various fixes --- .../sonar-web/design-system/src/components/Tooltip.tsx | 2 ++ .../overview/branches/SoftwareImpactMeasureRating.tsx | 10 ++++------ .../src/main/js/components/controls/Tooltip.tsx | 3 +++ 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/server/sonar-web/design-system/src/components/Tooltip.tsx b/server/sonar-web/design-system/src/components/Tooltip.tsx index bf17f07979f..ccd863ae518 100644 --- a/server/sonar-web/design-system/src/components/Tooltip.tsx +++ b/server/sonar-web/design-system/src/components/Tooltip.tsx @@ -77,6 +77,8 @@ function isMeasured(state: State): state is OwnState & Measurements { * - `overlay` is now `content`, that's the tooltip content. It's a ReactNode for convenience but should render only text based content, no interactivity is allowed inside the tooltip. * - ~`mouseEnterDelay`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. * - ~`mouseLeaveDelay`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. + * - ~`onHide`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. + * - ~`onShow`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. * - `placement` is now `align` and `side`, based on the {@link Echoes.TooltipAlign | TooltipAlign} and {@link Echoes.TooltipSide | TooltipSide} enums. * - `visible` is now `isOpen` */ diff --git a/server/sonar-web/src/main/js/apps/overview/branches/SoftwareImpactMeasureRating.tsx b/server/sonar-web/src/main/js/apps/overview/branches/SoftwareImpactMeasureRating.tsx index 6f0f1f4bc7f..7fe77dd89a3 100644 --- a/server/sonar-web/src/main/js/apps/overview/branches/SoftwareImpactMeasureRating.tsx +++ b/server/sonar-web/src/main/js/apps/overview/branches/SoftwareImpactMeasureRating.tsx @@ -23,7 +23,7 @@ import * as React from 'react'; import { useIntl } from 'react-intl'; import { formatRating } from '../../../helpers/measures'; import { SoftwareQuality } from '../../../types/clean-code-taxonomy'; -import SoftwareImpactRatingTooltip from './SoftwareImpactRatingTooltip'; +import SoftwareImpactRatingTooltipContent from './SoftwareImpactRatingTooltip'; export interface SoftwareImpactMeasureRatingProps { softwareQuality: SoftwareQuality; @@ -37,11 +37,9 @@ export function SoftwareImpactMeasureRating(props: Readonly + ); return ( <> diff --git a/server/sonar-web/src/main/js/components/controls/Tooltip.tsx b/server/sonar-web/src/main/js/components/controls/Tooltip.tsx index af330ecdb91..ad75ca864d3 100644 --- a/server/sonar-web/src/main/js/components/controls/Tooltip.tsx +++ b/server/sonar-web/src/main/js/components/controls/Tooltip.tsx @@ -82,8 +82,11 @@ function isMeasured(state: State): state is OwnState & Measurements { * Some of the props have changed or been renamed: * - `children` is the trigger for the tooltip, should be an interactive Element. If not an Echoes component, make sure the component forwards the props and the ref to an interactive DOM node, it's needed by the tooltip to position itself. * - `overlay` is now `content`, that's the tooltip content. It's a ReactNode for convenience but should render only text based content, no interactivity is allowed inside the tooltip. + * - ~`classNameSpace`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. * - ~`mouseEnterDelay`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. * - ~`mouseLeaveDelay`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. + * - ~`onHide`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. + * - ~`onShow`~ doesn't exist anymore, was mostly used in situation that should be replaced by a Popover component. * - `placement` is now `align` and `side`, based on the {@link Echoes.TooltipAlign | TooltipAlign} and {@link Echoes.TooltipSide | TooltipSide} enums. * - `visible` is now `isOpen` */ -- 2.39.5