From dcc88b6c2d845ee81bfc092e6d2c9efea9422054 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Wed, 9 Nov 2016 17:23:19 +0100 Subject: [PATCH] SONAR-8377 Remove some code related to issue filters in rails --- .../main/webapp/WEB-INF/app/helpers/issues_helper.rb | 12 ------------ .../webapp/WEB-INF/app/helpers/properties_helper.rb | 9 --------- 2 files changed, 21 deletions(-) diff --git a/server/sonar-web/src/main/webapp/WEB-INF/app/helpers/issues_helper.rb b/server/sonar-web/src/main/webapp/WEB-INF/app/helpers/issues_helper.rb index 2bd8c7fdf1c..c59cbe2a756 100644 --- a/server/sonar-web/src/main/webapp/WEB-INF/app/helpers/issues_helper.rb +++ b/server/sonar-web/src/main/webapp/WEB-INF/app/helpers/issues_helper.rb @@ -19,18 +19,6 @@ # module IssuesHelper - def issue_filter_star(filter, is_favourite) - if is_favourite - style='icon-favorite' - title=message('click_to_remove_from_favorites') - else - style='icon-not-favorite' - title=message('click_to_add_to_favorites') - end - - "" - end - def can_be_reassigned_by(user, filter) user.has_role?(:admin) && filter.shared end diff --git a/server/sonar-web/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb b/server/sonar-web/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb index 408472e7a4f..b2b9c967586 100644 --- a/server/sonar-web/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb +++ b/server/sonar-web/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb @@ -73,15 +73,6 @@ module PropertiesHelper size = options[:size] || 50 text_field_tag name, value, {:size => size}.update(html_options) - when PropertyType::TYPE_ISSUE_FILTER - user_filters = options_id(value, Internal.issues.findIssueFiltersForCurrentUser()) - shared_filters = options_id(value, Internal.issues.findSharedFiltersForCurrentUser()) - - filters_combo = select_tag name, option_group('My Filters', user_filters) + option_group('Shared Filters', shared_filters), html_options - filter_link = link_to message('widget.filter.edit'), {:controller => 'issues', :action => 'manage'}, :class => 'link-action' - - "#{filters_combo} #{filter_link}" - when PropertyType::TYPE_SINGLE_SELECT_LIST default_value = options[:default].blank? ? '' : message('default') select_options = "" -- 2.39.5