From de35e37cba8be77be5d24c316e7afedc7797309a Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Wed, 18 Sep 2013 10:27:32 +0200 Subject: [PATCH] Fix quality flaws --- .../issue/notification/SendIssueNotificationsPostJob.java | 2 +- .../main/java/org/sonar/core/issue/IssueNotifications.java | 3 --- .../src/main/java/org/sonar/core/issue/IssuesBySeverity.java | 4 ++++ 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/issue/notification/SendIssueNotificationsPostJob.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/issue/notification/SendIssueNotificationsPostJob.java index 6f79d1bf85a..2e1fa1d575e 100644 --- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/issue/notification/SendIssueNotificationsPostJob.java +++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/issue/notification/SendIssueNotificationsPostJob.java @@ -74,7 +74,7 @@ public class SendIssueNotificationsPostJob implements PostJob { if (!shouldSentNotification.isEmpty()) { notifications.sendChanges(shouldSentNotification, context, project, null); } - if (newIssues.size() > 0) { + if (!newIssues.isEmpty()) { notifications.sendNewIssues(project, newIssues); } } diff --git a/sonar-core/src/main/java/org/sonar/core/issue/IssueNotifications.java b/sonar-core/src/main/java/org/sonar/core/issue/IssueNotifications.java index b157843c5d3..81ac9253acd 100644 --- a/sonar-core/src/main/java/org/sonar/core/issue/IssueNotifications.java +++ b/sonar-core/src/main/java/org/sonar/core/issue/IssueNotifications.java @@ -151,7 +151,4 @@ public class IssueNotifications implements BatchComponent, ServerComponent { .setFieldValue("projectKey", project.key()); } - private Locale getLocale() { - return Locale.ENGLISH; - } } diff --git a/sonar-core/src/main/java/org/sonar/core/issue/IssuesBySeverity.java b/sonar-core/src/main/java/org/sonar/core/issue/IssuesBySeverity.java index ca9691aed2e..91bc91c220f 100644 --- a/sonar-core/src/main/java/org/sonar/core/issue/IssuesBySeverity.java +++ b/sonar-core/src/main/java/org/sonar/core/issue/IssuesBySeverity.java @@ -42,4 +42,8 @@ public class IssuesBySeverity { public int size() { return issuesBySeverity.values().size(); } + + public boolean isEmpty() { + return issuesBySeverity.values().isEmpty(); + } } -- 2.39.5