From deb3848a482936679f866e16924b77827825d4b6 Mon Sep 17 00:00:00 2001 From: Anna Koskinen Date: Mon, 11 Aug 2014 15:03:31 +0300 Subject: [PATCH] ComboBoxValueInput test upgrade (#14292) Change-Id: Id2158d0990f12940f2206095b8edc0946977f27d --- .../combobox/ComboBoxValueInput.html | 292 ------------- .../combobox/ComboBoxValueInput.java | 9 +- .../combobox/ComboBoxValueInputTest.java | 392 ++++++++++++++++++ 3 files changed, 397 insertions(+), 296 deletions(-) delete mode 100644 uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInput.html create mode 100644 uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInputTest.java diff --git a/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInput.html b/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInput.html deleted file mode 100644 index 2aab40f13f..0000000000 --- a/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInput.html +++ /dev/null @@ -1,292 +0,0 @@ - - - - - - -ComboBoxValueInput - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
ComboBoxValueInput
open/run/com.vaadin.tests.components.combobox.ComboBoxValueInput
screenCapture
waitForVaadin
clickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[0]/VFilterSelect[0]/domChild[1]
waitForVaadin
screenCapture
waitForVaadin
mouseClick//div[@id='VAADIN_COMBOBOX_OPTIONLIST']/div/div[2]/table/tbody/tr[3]/td58,6
waitForVaadin
mouseClickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[1]/VFilterSelect[0]/domChild[0]96,14
waitForVaadin
screenCapture
clickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[1]/VFilterSelect[0]/domChild[1]
waitForVaadin
screenCapture
mouseClick//div[@id='VAADIN_COMBOBOX_OPTIONLIST']/div/div[2]/table/tbody/tr[4]/td/span29,6
waitForVaadin
clickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[1]
waitForVaadin
screenCapture
mouseClick//div[@id='VAADIN_COMBOBOX_OPTIONLIST']/div/div[2]/table/tbody/tr[3]/td99,13
waitForVaadin
mouseClickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[1]
waitForVaadin
mouseClick//div[@id='VAADIN_COMBOBOX_OPTIONLIST']/div/div[2]/table/tbody/tr[1]/td97,14
waitForVaadin
mouseClickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[0]68,17
waitForVaadin
enterCharactervaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[0]value
waitForVaadin
pressSpecialKeyvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[0]down
waitForVaadin
pressSpecialKeyvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[0]down
waitForVaadin
pressSpecialKeyvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[0]down
waitForVaadin
pressSpecialKeyvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[0]enter
waitForVaadin
screenCapture
waitForVaadin
mouseClickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[2]/VFilterSelect[0]/domChild[0]76,17
waitForVaadin
mouseClickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[3]/VFilterSelect[0]/domChild[1]
waitForVaadin
mouseClick//div[@id='VAADIN_COMBOBOX_OPTIONLIST']/div/div[2]/table/tbody/tr[2]/td71,11
waitForVaadin
clickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[3]/VFilterSelect[0]/domChild[1]
waitForVaadin
screenCapture
mouseClick//div[@id='VAADIN_COMBOBOX_OPTIONLIST']/div/div[2]/table/tbody/tr[1]/td58,9
waitForVaadin
mouseClickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[3]/VFilterSelect[0]/domChild[0]73,12
waitForVaadin
mouseClickvaadin=runcomvaadintestscomponentscomboboxComboBoxValueInput::/VVerticalLayout[0]/ChildComponentContainer[1]/VVerticalLayout[0]/ChildComponentContainer[5]/VFilterSelect[0]/domChild[0]43,7
waitForVaadin
- - diff --git a/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInput.java b/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInput.java index 356181238e..b0c1acb421 100644 --- a/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInput.java +++ b/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInput.java @@ -1,13 +1,14 @@ package com.vaadin.tests.components.combobox; +import com.vaadin.server.VaadinRequest; import com.vaadin.shared.ui.combobox.FilteringMode; -import com.vaadin.tests.components.TestBase; +import com.vaadin.tests.components.AbstractTestUI; import com.vaadin.ui.ComboBox; -public class ComboBoxValueInput extends TestBase { +public class ComboBoxValueInput extends AbstractTestUI { @Override - protected void setup() { + protected void setup(VaadinRequest request) { (getLayout()).setSpacing(true); ComboBox cb = getComboBox("A combobox", false); @@ -38,7 +39,7 @@ public class ComboBoxValueInput extends TestBase { } @Override - protected String getDescription() { + protected String getTestDescription() { return "A combobox should always show the selected value when it is not focused. Entering a text when nothing is selected and blurring the combobox should reset the value. The same should happen when a value is selected"; } diff --git a/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInputTest.java b/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInputTest.java new file mode 100644 index 0000000000..74879f66e8 --- /dev/null +++ b/uitest/src/com/vaadin/tests/components/combobox/ComboBoxValueInputTest.java @@ -0,0 +1,392 @@ +/* + * Copyright 2000-2014 Vaadin Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package com.vaadin.tests.components.combobox; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertTrue; + +import java.util.List; + +import org.junit.Before; +import org.junit.Test; +import org.openqa.selenium.Keys; +import org.openqa.selenium.WebElement; + +import com.vaadin.testbench.By; +import com.vaadin.testbench.elements.ComboBoxElement; +import com.vaadin.tests.tb3.MultiBrowserTest; + +/** + * Tests ComboBox inputs and selections. + * + * @author Vaadin Ltd + */ +public class ComboBoxValueInputTest extends MultiBrowserTest { + + @Override + @Before + public void setup() throws Exception { + super.setup(); + openTestURL(); + }; + + @Test + public void testOverall() { + List comboBoxes = $(ComboBoxElement.class).all(); + assertEquals("unexpected amount of comboboxes found", 6, + comboBoxes.size()); + } + + @Test + public void testFirstComboBoxInputs() { + ComboBoxElement comboBox = $(ComboBoxElement.class).all().get(0); + + // check the initial selection + assertEquals("correct selection not found", "", + comboBox.findElement(By.tagName("input")).getAttribute("value")); + + // ensure the combobox has suggested values + assertFalse("suggestions not found even if there should be several", + comboBox.getPopupSuggestions().isEmpty()); + + // check that the found items were correct ones + WebElement popup = driver.findElement(By + .className("v-filterselect-suggestpopup")); + List filteredItems = popup.findElement( + By.className("v-filterselect-suggestmenu")).findElements( + By.className("gwt-MenuItem")); + assertEquals("unexpected amount of suggestions found", 4, + filteredItems.size()); + assertEquals("wrong filtering result", " ", filteredItems.get(0) + .getText()); + assertEquals("wrong filtering result", "Value 1", filteredItems.get(1) + .getText()); + assertEquals("wrong filtering result", "Value 3", filteredItems.get(3) + .getText()); + + // select the second last item + filteredItems.get(2).click(); + + // ensure there's no more popup + assertFalse("popup found when there should be none", + comboBox.isElementPresent(By.vaadin("#popup"))); + + // check the updated selection + assertEquals("correct selection not found", "Value 2", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + } + + @Test + public void testSecondComboBoxInputs() { + ComboBoxElement comboBox = $(ComboBoxElement.class).all().get(1); + + // check the input prompt + assertEquals("correct input prompt not found", "Please select", + comboBox.findElement(By.tagName("input")).getAttribute("value")); + + // focus the combobox + comboBox.findElement(By.tagName("input")).click(); + + // check the input prompt has disappeared + assertEquals("correct input prompt not found", "", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + // ensure the combobox has suggested values + assertFalse("suggestions not found even if there should be several", + comboBox.getPopupSuggestions().isEmpty()); + + // check that the found items were correct ones + WebElement popup = driver.findElement(By + .className("v-filterselect-suggestpopup")); + List filteredItems = popup.findElement( + By.className("v-filterselect-suggestmenu")).findElements( + By.className("gwt-MenuItem")); + assertEquals("unexpected amount of suggestions found", 4, + filteredItems.size()); + assertEquals("wrong filtering result", " ", filteredItems.get(0) + .getText()); + assertEquals("wrong filtering result", "Value 1", filteredItems.get(1) + .getText()); + assertEquals("wrong filtering result", "Value 3", filteredItems.get(3) + .getText()); + + // select the last item + filteredItems.get(3).click(); + + // ensure there's no more popup + assertFalse("popup found when there should be none", + comboBox.isElementPresent(By.vaadin("#popup"))); + + // check the updated selection + assertEquals("correct selection not found", "Value 3", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + } + + @Test + public void testThirdComboBoxInputs() { + ComboBoxElement comboBox = $(ComboBoxElement.class).all().get(2); + + // check the null selection + assertEquals("correct selection not found", "Null item", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + // ensure the combobox has suggested values + assertFalse("suggestions not found even if there should be several", + comboBox.getPopupSuggestions().isEmpty()); + + // check that the found items were correct ones + WebElement popup = driver.findElement(By + .className("v-filterselect-suggestpopup")); + List filteredItems = popup.findElement( + By.className("v-filterselect-suggestmenu")).findElements( + By.className("gwt-MenuItem")); + assertEquals("unexpected amount of suggestions found", 4, + filteredItems.size()); + assertEquals("wrong filtering result", "Null item", filteredItems + .get(0).getText()); + assertEquals("wrong filtering result", "Value 1", filteredItems.get(1) + .getText()); + assertEquals("wrong filtering result", "Value 3", filteredItems.get(3) + .getText()); + + // ensure the null item is marked as selected + assertEquals("wrong selection", "Null item", + popup.findElement(By.className("v-filterselect-suggestmenu")) + .findElement(By.className("gwt-MenuItem-selected")) + .getText()); + + // select the second last item + filteredItems.get(2).click(); + + // ensure there's no more popup + assertFalse("popup found when there should be none", + comboBox.isElementPresent(By.vaadin("#popup"))); + + // check the updated selection + assertEquals("correct selection not found", "Value 2", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + // open the popup again + comboBox.openPopup(); + + // check that the found items were correct ones + popup = driver.findElement(By.className("v-filterselect-suggestpopup")); + filteredItems = popup.findElement( + By.className("v-filterselect-suggestmenu")).findElements( + By.className("gwt-MenuItem")); + assertEquals("unexpected amount of suggestions found", 4, + filteredItems.size()); + assertEquals("wrong filtering result", "Null item", filteredItems + .get(0).getText()); + assertEquals("wrong filtering result", "Value 1", filteredItems.get(1) + .getText()); + assertEquals("wrong filtering result", "Value 3", filteredItems.get(3) + .getText()); + + // ensure the selected item is marked as selected + assertEquals("wrong selection", "Value 2", + popup.findElement(By.className("v-filterselect-suggestmenu")) + .findElement(By.className("gwt-MenuItem-selected")) + .getText()); + + // select the first item again + filteredItems.get(0).click(); + + // ensure there's no more popup + assertFalse("popup found when there should be none", + comboBox.isElementPresent(By.vaadin("#popup"))); + + // check the displayed value didn't change + assertEquals("correct selection not found", "Null item", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + // enter a new filtering value + comboBox.findElement(By.tagName("input")).clear(); + comboBox.findElement(By.tagName("input")).sendKeys("value"); + + // ensure there's a popup again + assertTrue("popup not found when there should be one", + comboBox.isElementPresent(By.vaadin("#popup"))); + + // check that the found items were correct ones + popup = driver.findElement(By.className("v-filterselect-suggestpopup")); + filteredItems = popup.findElement( + By.className("v-filterselect-suggestmenu")).findElements( + By.className("gwt-MenuItem")); + assertEquals("unexpected amount of suggestions found", 3, + filteredItems.size()); + assertEquals("wrong filtering result", "Value 1", filteredItems.get(0) + .getText()); + assertEquals("wrong filtering result", "Value 3", filteredItems.get(2) + .getText()); + + // check the displayed value updated + assertEquals("correct selection not found", "value", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + comboBox.findElement(By.tagName("input")).sendKeys(Keys.ARROW_DOWN); + + // ensure the first item is marked as selected + assertEquals("wrong selection", "Value 1", + popup.findElement(By.className("v-filterselect-suggestmenu")) + .findElement(By.className("gwt-MenuItem-selected")) + .getText()); + + // navigate with keys to the last item + comboBox.findElement(By.tagName("input")).sendKeys(Keys.ARROW_DOWN); + comboBox.findElement(By.tagName("input")).sendKeys(Keys.ARROW_DOWN); + + // TODO: remove this limit once #14402 has been fixed + if (getBrowsersExcludingIE().contains(getDesiredCapabilities())) { + // ensure the last item is marked as selected + assertEquals( + "wrong selection", + "Value 3", + popup.findElement( + By.className("v-filterselect-suggestmenu")) + .findElement(By.className("gwt-MenuItem-selected")) + .getText()); + } + + // select the last item + comboBox.findElement(By.tagName("input")).sendKeys(Keys.RETURN); + + // TODO: remove this limit once #14402 has been fixed + if (getBrowsersExcludingIE().contains(getDesiredCapabilities())) { + // check the updated selection + assertEquals("correct selection not found", "Value 3", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + } + + // TODO: remove this altogether once #14402 has been fixed + if (Browser.PHANTOMJS.getDesiredCapabilities().equals( + getDesiredCapabilities())) { + // toggle popup closed since the RETURN didn't do it + comboBox.openPopup(); + } + + // ensure there's no more popup + assertFalse("popup found when there should be none", + comboBox.isElementPresent(By.vaadin("#popup"))); + } + + @Test + public void testFourthComboBoxInputs() { + ComboBoxElement comboBox = $(ComboBoxElement.class).all().get(3); + + // check the combobox displays the null selection instead of the input + // prompt + assertEquals("correct value not displayed", "Null item", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + // ensure the combobox has suggested values + assertFalse("suggestions not found even if there should be several", + comboBox.getPopupSuggestions().isEmpty()); + + // check that the found items were correct ones + WebElement popup = driver.findElement(By + .className("v-filterselect-suggestpopup")); + List filteredItems = popup.findElement( + By.className("v-filterselect-suggestmenu")).findElements( + By.className("gwt-MenuItem")); + assertEquals("unexpected amount of suggestions found", 4, + filteredItems.size()); + assertEquals("wrong filtering result", "Null item", filteredItems + .get(0).getText()); + assertEquals("wrong filtering result", "Value 1", filteredItems.get(1) + .getText()); + assertEquals("wrong filtering result", "Value 3", filteredItems.get(3) + .getText()); + + // ensure the null item is marked as selected + assertEquals("wrong selection", "Null item", + popup.findElement(By.className("v-filterselect-suggestmenu")) + .findElement(By.className("gwt-MenuItem-selected")) + .getText()); + + // select the second item + filteredItems.get(1).click(); + + // ensure there's no more popup + assertFalse("popup found when there should be none", + comboBox.isElementPresent(By.vaadin("#popup"))); + + // check the updated selection + assertEquals("correct selection not found", "Value 1", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + // open the popup again + comboBox.openPopup(); + waitForElementPresent(By.className("v-filterselect-suggestmenu")); + popup = driver.findElement(By.className("v-filterselect-suggestpopup")); + + // ensure the full selection remains + filteredItems = popup.findElement( + By.className("v-filterselect-suggestmenu")).findElements( + By.className("gwt-MenuItem")); + assertEquals("unexpected amount of suggestions found", 4, + filteredItems.size()); + + // ensure the selected item is marked as selected + assertEquals("wrong selection", "Value 1", + popup.findElement(By.className("v-filterselect-suggestmenu")) + .findElement(By.className("gwt-MenuItem-selected")) + .getText()); + + // select the null selection item + filteredItems.get(0).click(); + + // ensure there's no more popup + assertFalse("popup found when there should be none", + comboBox.isElementPresent(By.vaadin("#popup"))); + } + + @Test + public void testFifthComboBoxInputs() { + ComboBoxElement comboBox = $(ComboBoxElement.class).all().get(4); + + // check the initial selection + assertEquals("correct selection not found", "Null item", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + // check the disabled status + assertEquals("correct selection not found", "true", comboBox + .findElement(By.tagName("input")).getAttribute("disabled")); + + comboBox.openPopup(); + + // ensure there's no popup + assertFalse("popup found when there should be none", + comboBox.isElementPresent(By.vaadin("#popup"))); + } + + @Test + public void testSixthComboBoxInputs() { + ComboBoxElement comboBox = $(ComboBoxElement.class).all().get(5); + + // check the initial selection + assertEquals("correct selection not found", "Null item", comboBox + .findElement(By.tagName("input")).getAttribute("value")); + + // check the readonly status + assertEquals("correct selection not found", "true", comboBox + .findElement(By.tagName("input")).getAttribute("readonly")); + + assertFalse("button visible on readonly combobox", comboBox + .findElement(By.vaadin("#button")).isDisplayed()); + } +} -- 2.39.5