From ded151dae15f0d88c7f8c0a804afb8677ed31760 Mon Sep 17 00:00:00 2001 From: Anna Koskinen Date: Wed, 3 Nov 2021 17:26:26 +0200 Subject: [PATCH] GridThemeUITest fix (#12470) Attempt to stabilize the screenshot comparison by ensuring that the editor is fully opened. --- .../components/grid/GridThemeUITest.java | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/GridThemeUITest.java b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/GridThemeUITest.java index ccb5f10df2..519a012414 100644 --- a/uitest/src/test/java/com/vaadin/v7/tests/components/grid/GridThemeUITest.java +++ b/uitest/src/test/java/com/vaadin/v7/tests/components/grid/GridThemeUITest.java @@ -3,8 +3,10 @@ package com.vaadin.v7.tests.components.grid; import org.junit.Test; import org.openqa.selenium.By; import org.openqa.selenium.Keys; +import org.openqa.selenium.WebDriver; import org.openqa.selenium.WebElement; import org.openqa.selenium.interactions.Actions; +import org.openqa.selenium.support.ui.ExpectedCondition; import com.vaadin.testbench.elements.ButtonElement; import com.vaadin.testbench.elements.DateFieldElement; @@ -76,7 +78,25 @@ public class GridThemeUITest extends MultiBrowserThemeTest { new Actions(getDriver()).doubleClick(targetCell).perform(); waitForElementPresent(By.className("v-grid-editor")); } - + WebElement editor = findElement(By.className("v-grid-editor")); + waitUntil(new ExpectedCondition() { + @Override + public Boolean apply(WebDriver arg0) { + int current = editor.getSize().getHeight(); + // it's actually expected to be the height of two rows plus one + // pixel, but giving it 2 pixels of leeway + int expected = targetCell.getSize().getHeight() * 2 - 1; + return current >= expected; + } + + @Override + public String toString() { + // Expected condition failed: waiting for ... + return "editor to become visible, current height: " + + editor.getSize().getHeight() + ", row height: " + + targetCell.getSize().getHeight(); + } + }); } private void selectPage(String string) { -- 2.39.5