From e096fa2531250b2331c1d9d45971270c4b826b0c Mon Sep 17 00:00:00 2001 From: Vsevolod Stakhov Date: Wed, 25 Mar 2015 00:01:34 +0000 Subject: [PATCH] Use cumulative moving average for time values. The previous version with exponential moving average cannot work well with the rspamd usage pattern. --- src/libserver/symbols_cache.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/libserver/symbols_cache.c b/src/libserver/symbols_cache.c index 3fa90fbd3..4f37de867 100644 --- a/src/libserver/symbols_cache.c +++ b/src/libserver/symbols_cache.c @@ -91,14 +91,16 @@ static double rspamd_set_counter (struct cache_item *item, guint32 value) { struct counter_data *cd; - double alpha; cd = item->cd; - /* Calculate new value */ + /* Cumulative moving average */ rspamd_mempool_lock_mutex (item->mtx); - alpha = 2. / (++cd->number + 1); - cd->value = cd->value * (1. - alpha) + value * alpha; + if (cd->number == 0) { + cd->value = 0; + } + + cd->value = cd->value + (value - cd->value) / (++cd->number); rspamd_mempool_unlock_mutex (item->mtx); -- 2.39.5