From e56582fb8ff7dd82235f36bbd4eb8119c1d8bb10 Mon Sep 17 00:00:00 2001
From: Olivier Lamy <olamy@apache.org>
Date: Fri, 10 Feb 2012 17:24:11 +0000
Subject: [PATCH] [MRM-1576] rewrite proxies connector page fix update of
 properties.

git-svn-id: https://svn.apache.org/repos/asf/archiva/trunk@1242863 13f79535-47bb-0310-9956-ffa450edef68
---
 .../model/AbstractRepositoryConnector.java    |  2 +-
 .../webapp/js/archiva/proxy-connectors.js     | 44 ++++++++++---------
 .../archiva/templates/proxy-connectors.html   |  4 +-
 3 files changed, 26 insertions(+), 24 deletions(-)

diff --git a/archiva-modules/archiva-base/archiva-repository-admin/archiva-repository-admin-api/src/main/java/org/apache/archiva/admin/model/AbstractRepositoryConnector.java b/archiva-modules/archiva-base/archiva-repository-admin/archiva-repository-admin-api/src/main/java/org/apache/archiva/admin/model/AbstractRepositoryConnector.java
index 4efc1a818..f6afff08c 100644
--- a/archiva-modules/archiva-base/archiva-repository-admin/archiva-repository-admin-api/src/main/java/org/apache/archiva/admin/model/AbstractRepositoryConnector.java
+++ b/archiva-modules/archiva-base/archiva-repository-admin/archiva-repository-admin-api/src/main/java/org/apache/archiva/admin/model/AbstractRepositoryConnector.java
@@ -393,7 +393,7 @@ public abstract class AbstractRepositoryConnector
 
     public void setPropertiesEntries( List<PropertyEntry> propertiesEntries )
     {
-        for ( PropertyEntry propertyEntry : policiesEntries )
+        for ( PropertyEntry propertyEntry : propertiesEntries )
         {
             addProperty( propertyEntry.getKey(), propertyEntry.getValue() );
         }
diff --git a/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors.js b/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors.js
index bde340acb..ae0c71d3c 100644
--- a/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors.js
+++ b/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/proxy-connectors.js
@@ -88,27 +88,6 @@ $(function() {
     this.modified=ko.observable(false);
     this.modified.subscribe(function(newValue){$.log("ProxyConnector modified:"+newValue)});
 
-
-    this.deleteProperty=function(key){
-      $.log("delete property key:"+key());
-      for(i=0;i<self.propertiesEntries().length;i++){
-        var entry=self.propertiesEntries()[i];
-        if (entry.key()==key()){
-          self.propertiesEntries.remove(entry);
-        }
-      }
-
-    }
-
-    this.addProperty=function(){
-      var mainContent=$("#main-content");
-      var key=mainContent.find("#property-key").val();
-      var value=mainContent.find("#property-value").val();
-      var oldTab = self.propertiesEntries();
-      oldTab.push(new Entry(key,value));
-      self.propertiesEntries(oldTab);
-    }
-
     this.updatePolicyEntry=function(key,value){
       for(i=0;i<policiesEntries.length;i++){
         if (policiesEntries[i].key==key){
@@ -116,6 +95,7 @@ $(function() {
         }
       }
     }
+
   }
 
   PolicyInformation=function(options,defaultOption,id,name){
@@ -249,6 +229,28 @@ $(function() {
       }
     }
 
+    this.deleteProperty=function(key){
+      $.log("delete property key:"+key());
+      for(i=0;i<self.proxyConnector.propertiesEntries().length;i++){
+        var entry=self.proxyConnector.propertiesEntries()[i];
+        if (entry.key()==key()){
+          self.proxyConnector.propertiesEntries.remove(entry);
+        }
+      }
+
+    }
+
+    this.addProperty=function(){
+      var mainContent=$("#main-content");
+      var key=mainContent.find("#property-key").val();
+      var value=mainContent.find("#property-value").val();
+      var oldTab = self.proxyConnector.propertiesEntries();
+      oldTab.push(new Entry(key,value));
+      self.proxyConnector.propertiesEntries(oldTab);
+      mainContent.find("#property-key").val("");
+      mainContent.find("#property-value").val("");
+    }
+
     displayGrid=function(){
       activateProxyConnectorsGridTab();
     }
diff --git a/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/templates/proxy-connectors.html b/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/templates/proxy-connectors.html
index b32e8bc04..b278748d2 100644
--- a/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/templates/proxy-connectors.html
+++ b/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/templates/proxy-connectors.html
@@ -163,13 +163,13 @@
               <thead>
                 <th><input type="text" id="property-key"/></th>
                 <th><input type="text" id="property-value"/></th>
-                <th><a href="#" data-bind="click: function(){ proxyConnector.addProperty() }">${$.i18n.prop('add')}</a></th>
+                <th><a href="#" data-bind="click: function(){ addProperty() }">${$.i18n.prop('add')}</a></th>
               </thead>
               <tbody data-bind="foreach: proxyConnector.propertiesEntries">
                 <tr>
                   <td data-bind="text: key"></td>
                   <td data-bind="text: value"></td>
-                  <td><a href="#" data-bind="click: function(){$data.deleteProperty(key)}">${$.i18n.prop('delete')}</a></td>
+                  <td><a href="#" data-bind="click: function(){ $parent.deleteProperty(key)}">${$.i18n.prop('delete')}</a></td>
                 </tr>
               </tbody>
             </table>
-- 
2.39.5