From e580dbc6a3eb89c4596484ca276f1899d6276ebb Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Tue, 22 Mar 2011 07:48:04 +0000 Subject: [PATCH] scm: code clean up test/functional/repositories_controller_test.rb. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5194 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .../repositories_controller_test.rb | 35 +++++++++++++------ 1 file changed, 24 insertions(+), 11 deletions(-) diff --git a/test/functional/repositories_controller_test.rb b/test/functional/repositories_controller_test.rb index 629be69ed..984da66f4 100644 --- a/test/functional/repositories_controller_test.rb +++ b/test/functional/repositories_controller_test.rb @@ -22,15 +22,17 @@ require 'repositories_controller' class RepositoriesController; def rescue_action(e) raise e end; end class RepositoriesControllerTest < ActionController::TestCase - fixtures :projects, :users, :roles, :members, :member_roles, :repositories, :issues, :issue_statuses, :changesets, :changes, :issue_categories, :enumerations, :custom_fields, :custom_values, :trackers - + fixtures :projects, :users, :roles, :members, :member_roles, + :repositories, :issues, :issue_statuses, :changesets, :changes, + :issue_categories, :enumerations, :custom_fields, :custom_values, :trackers + def setup @controller = RepositoriesController.new @request = ActionController::TestRequest.new @response = ActionController::TestResponse.new User.current = nil end - + def test_revisions get :revisions, :id => 1 assert_response :success @@ -44,7 +46,7 @@ class RepositoriesControllerTest < ActionController::TestCase assert_not_nil assigns(:changeset) assert_equal "1", assigns(:changeset).revision end - + def test_revision_with_before_nil_and_afer_normal get :revision, {:id => 1, :rev => 1} assert_response :success @@ -56,24 +58,30 @@ class RepositoriesControllerTest < ActionController::TestCase :child => { :tag => "a", :attributes => { :href => '/projects/ecookbook/repository/revisions/2'} } end - + def test_graph_commits_per_month get :graph, :id => 1, :graph => 'commits_per_month' assert_response :success assert_equal 'image/svg+xml', @response.content_type end - + def test_graph_commits_per_author get :graph, :id => 1, :graph => 'commits_per_author' assert_response :success assert_equal 'image/svg+xml', @response.content_type end - + def test_committers @request.session[:user_id] = 2 # add a commit with an unknown user - Changeset.create!(:repository => Project.find(1).repository, :committer => 'foo', :committed_on => Time.now, :revision => 100, :comments => 'Committed by foo.') - + Changeset.create!( + :repository => Project.find(1).repository, + :committer => 'foo', + :committed_on => Time.now, + :revision => 100, + :comments => 'Committed by foo.' + ) + get :committers, :id => 1 assert_response :success assert_template 'committers' @@ -94,8 +102,13 @@ class RepositoriesControllerTest < ActionController::TestCase def test_map_committers @request.session[:user_id] = 2 # add a commit with an unknown user - c = Changeset.create!(:repository => Project.find(1).repository, :committer => 'foo', :committed_on => Time.now, :revision => 100, :comments => 'Committed by foo.') - + c = Changeset.create!( + :repository => Project.find(1).repository, + :committer => 'foo', + :committed_on => Time.now, + :revision => 100, + :comments => 'Committed by foo.' + ) assert_no_difference "Changeset.count(:conditions => 'user_id = 3')" do post :committers, :id => 1, :committers => { '0' => ['foo', '2'], '1' => ['dlopper', '3']} assert_redirected_to '/projects/ecookbook/repository/committers' -- 2.39.5