From e78cfb1a3756773aec24e83e358e1e4b40f2a116 Mon Sep 17 00:00:00 2001 From: Richard Gibson Date: Fri, 9 Nov 2012 23:43:46 -0500 Subject: [PATCH] Fix #12858: don't expose jQuery/Sizzle expandos --- src/sizzle | 2 +- test/unit/manipulation.js | 19 ++++++++++++++----- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/src/sizzle b/src/sizzle index 5e6ae330a..7ea8b52ed 160000 --- a/src/sizzle +++ b/src/sizzle @@ -1 +1 @@ -Subproject commit 5e6ae330a9ccb33fd343a0bdc73ed2b821767f9c +Subproject commit 7ea8b52ed6f4e3026216037c00a24edd9fce4fff diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js index 98e011232..6c37e5196 100644 --- a/test/unit/manipulation.js +++ b/test/unit/manipulation.js @@ -1241,17 +1241,14 @@ test("jQuery.clone() (#8017)", function() { equal( main.childNodes.length, clone.childNodes.length, "Simple child length to ensure a large dom tree copies correctly" ); }); -test("clone() (#8070)", function () { +test("append to multiple elements (#8070)", function () { expect(2); - jQuery("").appendTo("#qunit-fixture"); - var selects = jQuery(".test8070"); + var selects = jQuery("").appendTo("#qunit-fixture"); selects.append(""); equal( selects[0].childNodes.length, 2, "First select got two nodes" ); equal( selects[1].childNodes.length, 2, "Second select got two nodes" ); - - selects.remove(); }); test("clone()", function() { @@ -1614,6 +1611,18 @@ test("html(Function) with incoming value", function() { }).html().replace(/>/g, ">"), " " + insert, "Verify escaped insertion." ); }); +test("clone()/html() don't expose jQuery/Sizzle expandos (#12858)", function() { + expect(2); + var $content = jQuery("
text
").appendTo("#qunit-fixture"), + expected = /^text<\/i><\/b>$/i; + + // Attach jQuery and Sizzle data (the latter by conducting a non-qSA search) + $content.find(":nth-child(1):lt(4)").data( "test", true ); + + ok( expected.test( $content.clone( false )[0].innerHTML ), "clone()" ); + ok( expected.test( $content.html() ), "html()" ); +}); + var testRemove = function(method) { var first = jQuery("#ap").children(":first"); -- 2.39.5