From e7e4d9f3fea348a80388f7cfd9fedfb48b9c799c Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Tue, 22 Jul 2014 21:12:53 +0200
Subject: [PATCH] Fix quality flaws

---
 server/sonar-web/src/main/js/application.js                 | 6 +++---
 .../src/main/js/navigator/filters/choice-filters.js         | 3 +++
 server/sonar-web/src/main/js/translate.js                   | 6 ++----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/server/sonar-web/src/main/js/application.js b/server/sonar-web/src/main/js/application.js
index e84f1158318..730edbfc0e0 100644
--- a/server/sonar-web/src/main/js/application.js
+++ b/server/sonar-web/src/main/js/application.js
@@ -70,10 +70,10 @@ var SelectBox = {
   cache: {},
   init: function (id) {
     var box = document.getElementById(id);
-    var node;
     SelectBox.cache[id] = [];
     var cache = SelectBox.cache[id];
-    for (var i = 0; (node = box.options[i]); i++) {
+    for (var i = 0, j = box.options.length; i < j; i++) {
+      var node = box.options[i];
       cache.push({value: node.value, text: node.text, displayed: 1});
     }
   },
@@ -98,7 +98,7 @@ var SelectBox = {
       node.displayed = 1;
       for (var j = 0, k = tokens.length; j < k; j++) {
         var token = tokens[j];
-        if (node.text.toLowerCase().indexOf(token) == -1) {
+        if (node.text.toLowerCase().indexOf(token) === -1) {
           node.displayed = 0;
         }
       }
diff --git a/server/sonar-web/src/main/js/navigator/filters/choice-filters.js b/server/sonar-web/src/main/js/navigator/filters/choice-filters.js
index b368384be9c..3dec5f94708 100644
--- a/server/sonar-web/src/main/js/navigator/filters/choice-filters.js
+++ b/server/sonar-web/src/main/js/navigator/filters/choice-filters.js
@@ -122,6 +122,9 @@ define([
           e.preventDefault();
           this.selectCurrent();
           break;
+        default:
+          // Not a functional key - then skip
+          break;
       }
     },
 
diff --git a/server/sonar-web/src/main/js/translate.js b/server/sonar-web/src/main/js/translate.js
index e6fd9b2f16a..bf2f7f47626 100644
--- a/server/sonar-web/src/main/js/translate.js
+++ b/server/sonar-web/src/main/js/translate.js
@@ -2,10 +2,8 @@
   window.suppressTranslationWarnings = false;
 
   var warn = function(message) {
-    if (!window.suppressTranslationWarnings) {
-      if (console != null && typeof console.warn === 'function') {
-        console.warn(message);
-      }
+    if (!window.suppressTranslationWarnings && console != null && typeof console.warn === 'function') {
+      console.warn(message);
     }
   };
 
-- 
2.39.5