From e895d21a52c6d54da2151b72a56ed193ade5be7e Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Mon, 18 Dec 2017 10:19:53 +0900 Subject: [PATCH] Remove redundant @SuppressWarnings("unused") These are now redundant since the parameters have javadoc. Change-Id: I6bfde267e1712ee35871c30c8203c3b4dc5e136a Signed-off-by: David Pursehouse --- .../org/eclipse/jgit/junit/http/RecordingLogger.java | 12 ++++-------- .../src/org/eclipse/jgit/pgm/Status.java | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/org.eclipse.jgit.junit.http/src/org/eclipse/jgit/junit/http/RecordingLogger.java b/org.eclipse.jgit.junit.http/src/org/eclipse/jgit/junit/http/RecordingLogger.java index 33b5fc056a..fed063a8fa 100644 --- a/org.eclipse.jgit.junit.http/src/org/eclipse/jgit/junit/http/RecordingLogger.java +++ b/org.eclipse.jgit.junit.http/src/org/eclipse/jgit/junit/http/RecordingLogger.java @@ -163,9 +163,7 @@ public class RecordingLogger implements Logger { * @param arg0 * @param arg1 */ - public void debug(@SuppressWarnings("unused") String msg, - @SuppressWarnings("unused") Object arg0, - @SuppressWarnings("unused") Object arg1) { + public void debug(String msg, Object arg0, Object arg1) { // Ignore (not relevant to test failures) } @@ -181,7 +179,7 @@ public class RecordingLogger implements Logger { * @param msg * debug message */ - public void debug(@SuppressWarnings("unused") String msg) { + public void debug(String msg) { // Ignore (not relevant to test failures) } @@ -192,9 +190,7 @@ public class RecordingLogger implements Logger { * @param arg0 * @param arg1 */ - public void info(@SuppressWarnings("unused") String msg, - @SuppressWarnings("unused") Object arg0, - @SuppressWarnings("unused") Object arg1) { + public void info(String msg, Object arg0, Object arg1) { // Ignore (not relevant to test failures) } @@ -203,7 +199,7 @@ public class RecordingLogger implements Logger { * * @param msg */ - public void info(@SuppressWarnings("unused") String msg) { + public void info(String msg) { // Ignore (not relevant to test failures) } diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Status.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Status.java index 4238f207e0..fb2fd7e235 100644 --- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Status.java +++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Status.java @@ -327,7 +327,7 @@ class Status extends TextBuiltin { protected int printList(String status1, String status2, String status3, Collection list, Collection set1, Collection set2, - @SuppressWarnings("unused") Collection set3) + Collection set3) throws IOException { List sortedList = new ArrayList<>(list); java.util.Collections.sort(sortedList); -- 2.39.5