From ec758b71b1f9c603ebebe00bb357abdd04e43efa Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Sun, 19 Mar 2017 14:25:03 +0100 Subject: [PATCH] Parameter "deliveryId" of api/webhooks/delivery must be documented as required --- .../server/webhook/ws/WebhookDeliveryAction.java | 1 + .../server/webhook/ws/WebhookDeliveryActionTest.java | 11 +++++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java b/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java index 41e5bb65ff9..57a08fd08f6 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java @@ -65,6 +65,7 @@ public class WebhookDeliveryAction implements WebhooksWsAction { action.createParam(PARAM_ID) .setDescription("Id of delivery") + .setRequired(true) .setExampleValue(Uuids.UUID_EXAMPLE_06); } diff --git a/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java b/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java index ecbc6e757dc..987525d559a 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java @@ -69,10 +69,13 @@ public class WebhookDeliveryActionTest { @Test public void test_definition() { - assertThat(ws.getDef().params()).extracting(WebService.Param::key).containsOnly("deliveryId"); - assertThat(ws.getDef().isPost()).isFalse(); - assertThat(ws.getDef().isInternal()).isFalse(); - assertThat(ws.getDef().responseExampleAsString()).isNotEmpty(); + WebService.Action definition = ws.getDef(); + assertThat(definition.isPost()).isFalse(); + assertThat(definition.isInternal()).isFalse(); + assertThat(definition.responseExampleAsString()).isNotEmpty(); + + assertThat(definition.params()).hasSize(1); + assertThat(definition.param("deliveryId").isRequired()).isTrue(); } @Test -- 2.39.5