From ec9ac9441625bdc759626d305cd1e858666fb646 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Wed, 19 Jul 2017 17:00:39 +0200 Subject: [PATCH] WS batch/issues must return 400 if requested component type is not supported --- .../src/main/java/org/sonar/server/batch/IssuesAction.java | 2 +- .../src/test/java/org/sonar/server/batch/IssuesActionTest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/batch/IssuesAction.java b/server/sonar-server/src/main/java/org/sonar/server/batch/IssuesAction.java index d53b87ea481..d7f79bf0e3d 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/batch/IssuesAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/batch/IssuesAction.java @@ -102,7 +102,7 @@ public class IssuesAction implements BatchWsAction { break; default: // only projects, modules and files are supported. Other types of components are not allowed. - throw new IllegalStateException(format("Component of scope '%s' is not allowed", component.scope())); + throw new IllegalArgumentException(format("Component of scope '%s' is not allowed", component.scope())); } } } diff --git a/server/sonar-server/src/test/java/org/sonar/server/batch/IssuesActionTest.java b/server/sonar-server/src/test/java/org/sonar/server/batch/IssuesActionTest.java index 746bce1adfb..b3d9f40c408 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/batch/IssuesActionTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/batch/IssuesActionTest.java @@ -202,7 +202,7 @@ public class IssuesActionTest { ComponentDto directory = db.components().insertComponent(newDirectory(project, "src/main/java")); addPermissionTo(project); - expectedException.expect(IllegalStateException.class); + expectedException.expect(IllegalArgumentException.class); expectedException.expectMessage("Component of scope 'DIR' is not allowed"); call(directory.key()); -- 2.39.5