From eda997f2bd6e969753ca90c400b790427b2bf684 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Fri, 13 May 2022 15:06:47 +0200 Subject: [PATCH] only log diagnostic events if a treshhold is set this prevents log spam and it's rare that you actually want to very short events logged anyway Signed-off-by: Robin Appelman --- config/config.sample.php | 4 +++- lib/private/Diagnostics/EventLogger.php | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/config/config.sample.php b/config/config.sample.php index 5c34563f63d..bf6643458fa 100644 --- a/config/config.sample.php +++ b/config/config.sample.php @@ -1791,7 +1791,7 @@ $CONFIG = [ /** * Enforce the user theme. This will disable the user theming settings - * This must be a valid ITheme ID. + * This must be a valid ITheme ID. * E.g. light, dark, highcontrast, dark-highcontrast... */ 'enforce_theme' => '', @@ -2146,6 +2146,8 @@ $CONFIG = [ /** * Limit diagnostics event logging to events longer than the configured threshold in ms + * + * when set to 0 no diagnostics events will be logged */ 'diagnostics.logging.threshold' => 0, diff --git a/lib/private/Diagnostics/EventLogger.php b/lib/private/Diagnostics/EventLogger.php index c7b89002ea9..7b9bd9630ab 100644 --- a/lib/private/Diagnostics/EventLogger.php +++ b/lib/private/Diagnostics/EventLogger.php @@ -126,7 +126,7 @@ class EventLogger implements IEventLogger { $timeInMs = round($duration * 1000, 4); $loggingMinimum = (int)$this->config->getValue('diagnostics.logging.threshold', 0); - if ($loggingMinimum > 0 && $timeInMs < $loggingMinimum) { + if ($loggingMinimum === 0 || $timeInMs < $loggingMinimum) { return; } -- 2.39.5