From f1c29cdb8c8b6b9526f25321d606f5bfc374c209 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Sun, 2 Jun 2019 23:39:15 +0000 Subject: [PATCH] Run test only when GhostScript is available (#22481). Patch by Marius BALTEANU. git-svn-id: http://svn.redmine.org/redmine/trunk@18221 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .../functional/attachments_controller_test.rb | 24 +++++++++++-------- test/test_helper.rb | 8 +++++++ 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/test/functional/attachments_controller_test.rb b/test/functional/attachments_controller_test.rb index a78403254..f94c73280 100644 --- a/test/functional/attachments_controller_test.rb +++ b/test/functional/attachments_controller_test.rb @@ -404,16 +404,6 @@ class AttachmentsControllerTest < Redmine::ControllerTest assert_response 304 end - def test_thumbnail_for_pdf_should_be_png - Attachment.clear_thumbnails - @request.session[:user_id] = 2 - get :thumbnail, :params => { - :id => 23 # ecookbook-gantt.pdf - } - assert_response :success - assert_equal 'image/png', response.content_type - end - def test_thumbnail_should_not_exceed_maximum_size Redmine::Thumbnail.expects(:generate).with {|source, target, size| size == 800} @@ -463,6 +453,20 @@ class AttachmentsControllerTest < Redmine::ControllerTest puts '(ImageMagick convert not available)' end + if gs_installed? + def test_thumbnail_for_pdf_should_be_png + Attachment.clear_thumbnails + @request.session[:user_id] = 2 + get :thumbnail, :params => { + :id => 23 # ecookbook-gantt.pdf + } + assert_response :success + assert_equal 'image/png', response.content_type + end + else + puts '(GhostScript convert not available)' + end + def test_edit_all @request.session[:user_id] = 2 get :edit_all, :params => { diff --git a/test/test_helper.rb b/test/test_helper.rb index 521caeb3c..390ea92b4 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -134,6 +134,14 @@ class ActiveSupport::TestCase self.class.convert_installed? end + def self.gs_installed? + Redmine::Thumbnail.gs_available? + end + + def gs_installed? + self.class.gs_installed? + end + # Returns the path to the test +vendor+ repository def self.repository_path(vendor) path = Rails.root.join("tmp/test/#{vendor.downcase}_repository").to_s -- 2.39.5