From f486be8da1210c5e020180be4eed1c2ed315965a Mon Sep 17 00:00:00 2001 From: Josh Richards Date: Fri, 10 May 2024 08:23:32 -0400 Subject: [PATCH] fix: only compare minor mariadb version differences Signed-off-by: Josh Richards --- apps/settings/lib/SetupChecks/SupportedDatabase.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/settings/lib/SetupChecks/SupportedDatabase.php b/apps/settings/lib/SetupChecks/SupportedDatabase.php index d073f4f39dc..b2ae6f5a147 100644 --- a/apps/settings/lib/SetupChecks/SupportedDatabase.php +++ b/apps/settings/lib/SetupChecks/SupportedDatabase.php @@ -62,7 +62,9 @@ class SupportedDatabase implements ISetupCheck { $row = $result->fetch(); $version = $row['Value']; $versionlc = strtolower($version); - + // we only care about X.Y not X.Y.Z differences + [$major, $minor, ] = explode('.', $versionlc); + $versionlc = $major . '.' . $minor; if (str_contains($versionlc, 'mariadb')) { if (version_compare($versionlc, '10.3', '<') || version_compare($versionlc, '10.11', '>')) { return SetupResult::warning($this->l10n->t('MariaDB version "%s" detected. MariaDB >=10.3 and <=10.11 is suggested for best performance, stability and functionality with this version of Nextcloud.', $version)); -- 2.39.5