From f5c674d695ae510cf4184c6388fa58a8c86f532d Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Thu, 9 Mar 2017 23:38:57 +0100 Subject: [PATCH] Make web services api/webhooks/* public --- .../org/sonar/server/webhook/ws/WebhookDeliveriesAction.java | 1 - .../java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java | 1 - .../sonar/server/webhook/ws/WebhookDeliveriesActionTest.java | 2 +- .../org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java | 2 +- 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveriesAction.java b/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveriesAction.java index 0519aac7a00..08562c8f600 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveriesAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveriesAction.java @@ -64,7 +64,6 @@ public class WebhookDeliveriesAction implements WebhooksWsAction { "Require 'Administer' permission on the related project.
" + "Note that additional information are returned by api/webhooks/delivery.") .setResponseExample(Resources.getResource(this.getClass(), "example-deliveries.json")) - .setInternal(true) .setHandler(this); action.createParam(COMPONENT_PARAM) diff --git a/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java b/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java index f60a7de8b16..41e5bb65ff9 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/webhook/ws/WebhookDeliveryAction.java @@ -61,7 +61,6 @@ public class WebhookDeliveryAction implements WebhooksWsAction { "Require 'Administer System' permission.
" + "Note that additional information are returned by api/webhooks/delivery.") .setResponseExample(Resources.getResource(this.getClass(), "example-delivery.json")) - .setInternal(true) .setHandler(this); action.createParam(PARAM_ID) diff --git a/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveriesActionTest.java b/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveriesActionTest.java index 3303a74a1f4..abcab6adcce 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveriesActionTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveriesActionTest.java @@ -70,7 +70,7 @@ public class WebhookDeliveriesActionTest { public void test_definition() { assertThat(ws.getDef().params()).extracting(WebService.Param::key).containsOnly("componentKey", "ceTaskId"); assertThat(ws.getDef().isPost()).isFalse(); - assertThat(ws.getDef().isInternal()).isTrue(); + assertThat(ws.getDef().isInternal()).isFalse(); assertThat(ws.getDef().responseExampleAsString()).isNotEmpty(); } diff --git a/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java b/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java index ff7921f46cb..ecbc6e757dc 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/webhook/ws/WebhookDeliveryActionTest.java @@ -71,7 +71,7 @@ public class WebhookDeliveryActionTest { public void test_definition() { assertThat(ws.getDef().params()).extracting(WebService.Param::key).containsOnly("deliveryId"); assertThat(ws.getDef().isPost()).isFalse(); - assertThat(ws.getDef().isInternal()).isTrue(); + assertThat(ws.getDef().isInternal()).isFalse(); assertThat(ws.getDef().responseExampleAsString()).isNotEmpty(); } -- 2.39.5