From f716dca60b060d4386a1bd9c54f0ef7c2df10c0c Mon Sep 17 00:00:00 2001
From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Tue, 17 Apr 2018 13:36:39 +0200
Subject: [PATCH] SONAR-10594 remove unused RuleRepositoryDao#selectByKey()

---
 .../main/java/org/sonar/db/rule/RuleRepositoryDao.java |  5 -----
 .../org/sonar/db/rule/RuleRepositoryMapper.xml         |  6 ------
 .../java/org/sonar/db/rule/RuleRepositoryDaoTest.java  | 10 ----------
 3 files changed, 21 deletions(-)

diff --git a/server/sonar-db-dao/src/main/java/org/sonar/db/rule/RuleRepositoryDao.java b/server/sonar-db-dao/src/main/java/org/sonar/db/rule/RuleRepositoryDao.java
index 4e1d4563ae0..1d9775d8a3e 100644
--- a/server/sonar-db-dao/src/main/java/org/sonar/db/rule/RuleRepositoryDao.java
+++ b/server/sonar-db-dao/src/main/java/org/sonar/db/rule/RuleRepositoryDao.java
@@ -21,7 +21,6 @@ package org.sonar.db.rule;
 
 import java.util.Collection;
 import java.util.List;
-import java.util.Optional;
 import org.sonar.api.utils.System2;
 import org.sonar.db.Dao;
 import org.sonar.db.DbSession;
@@ -50,10 +49,6 @@ public class RuleRepositoryDao implements Dao {
     return dbSession.getMapper(RuleRepositoryMapper.class).selectByLanguage(language);
   }
 
-  public Optional<RuleRepositoryDto> selectByKey(DbSession dbSession, String key) {
-    return Optional.ofNullable(dbSession.getMapper(RuleRepositoryMapper.class).selectByKey(key));
-  }
-
   public void truncate(DbSession dbSession) {
     dbSession.getMapper(RuleRepositoryMapper.class).truncate();
   }
diff --git a/server/sonar-db-dao/src/main/resources/org/sonar/db/rule/RuleRepositoryMapper.xml b/server/sonar-db-dao/src/main/resources/org/sonar/db/rule/RuleRepositoryMapper.xml
index 1e9ad4f9889..33596dd920e 100644
--- a/server/sonar-db-dao/src/main/resources/org/sonar/db/rule/RuleRepositoryMapper.xml
+++ b/server/sonar-db-dao/src/main/resources/org/sonar/db/rule/RuleRepositoryMapper.xml
@@ -20,12 +20,6 @@
     order by kee
   </select>
 
-  <select id="selectByKey" parameterType="String" resultType="org.sonar.db.rule.RuleRepositoryDto">
-    select <include refid="sqlColumns"/>
-    from rule_repositories
-    where kee = #{key}
-  </select>
-
   <update id="truncate">
     delete from rule_repositories
   </update>
diff --git a/server/sonar-db-dao/src/test/java/org/sonar/db/rule/RuleRepositoryDaoTest.java b/server/sonar-db-dao/src/test/java/org/sonar/db/rule/RuleRepositoryDaoTest.java
index 84f7883125f..3e90955f27c 100644
--- a/server/sonar-db-dao/src/test/java/org/sonar/db/rule/RuleRepositoryDaoTest.java
+++ b/server/sonar-db-dao/src/test/java/org/sonar/db/rule/RuleRepositoryDaoTest.java
@@ -88,16 +88,6 @@ public class RuleRepositoryDaoTest {
     assertThat(underTest.selectByLanguage(dbSession, "missing")).hasSize(0);
   }
 
-  @Test
-  public void selectByKey() {
-    DbSession dbSession = dbTester.getSession();
-    RuleRepositoryDto dto1 = new RuleRepositoryDto("findbugs", "java", "Findbugs");
-    underTest.insert(dbSession, asList(dto1));
-
-    assertThat(underTest.selectByKey(dbSession, "findbugs").get().getKey()).isEqualTo("findbugs");
-    assertThat(underTest.selectByKey(dbSession, "missing")).isNotPresent();
-  }
-
   @Test
   public void truncate() {
     DbSession dbSession = dbTester.getSession();
-- 
2.39.5