From f793340077d0acb9fb8724122f8b49160e78a69c Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Sun, 15 Oct 2017 11:42:32 +0000 Subject: [PATCH] Merged r16997 (#26667). git-svn-id: http://svn.redmine.org/redmine/branches/3.4-stable@16998 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/time_entry_query.rb | 3 +-- test/functional/queries_controller_test.rb | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/app/models/time_entry_query.rb b/app/models/time_entry_query.rb index 6591973f6..f432fdbcc 100644 --- a/app/models/time_entry_query.rb +++ b/app/models/time_entry_query.rb @@ -35,8 +35,7 @@ class TimeEntryQuery < Query def initialize(attributes=nil, *args) super attributes - self.filters ||= {} - add_filter('spent_on', '*') unless filters.present? + self.filters ||= { 'spent_on' => {:operator => "*", :values => []} } end def initialize_available_filters diff --git a/test/functional/queries_controller_test.rb b/test/functional/queries_controller_test.rb index 4aac31540..6f3e3f664 100644 --- a/test/functional/queries_controller_test.rb +++ b/test/functional/queries_controller_test.rb @@ -567,4 +567,19 @@ class QueriesControllerTest < Redmine::ControllerTest json = ActiveSupport::JSON.decode(response.body) assert_include ["OnlineStore - Systemwide visible version", "7", "open"], json end + + def test_subproject_filter_time_entries_with_project_id_should_return_filter_values + @request.session[:user_id] = 2 + get :filter, :params => { + :project_id => 1, + :type => 'TimeEntryQuery', + :name => 'subproject_id' + } + + assert_response :success + assert_equal 'application/json', response.content_type + json = ActiveSupport::JSON.decode(response.body) + assert_equal 4, json.count + assert_include ["Private child of eCookbook","5"], json + end end -- 2.39.5