From f7ee1f6e59f0b465f5f64bf6ac52108e445efaac Mon Sep 17 00:00:00 2001 From: Rick Waldron Date: Mon, 18 Jun 2012 13:26:46 -0400 Subject: [PATCH] Update document.defaultView.getComputedStyle. Fixes #10373 --- src/css.js | 14 ++++++++------ src/support.js | 5 +++++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/src/css.js b/src/css.js index d23284a1c..ac70a98d0 100644 --- a/src/css.js +++ b/src/css.js @@ -274,15 +274,17 @@ jQuery.extend({ } }); -if ( document.defaultView && document.defaultView.getComputedStyle ) { +// NOTE: To any future maintainer, we've used both window.getComputedStyle +// and window.getComputedStyle here to produce a better gzip size +if ( window.getComputedStyle ) { curCSS = function( elem, name ) { - var ret, defaultView, computedStyle, width, + var ret, width, + computed = getComputedStyle( elem, null ), style = elem.style; - if ( (defaultView = elem.ownerDocument.defaultView) && - (computedStyle = defaultView.getComputedStyle( elem, null )) ) { + if ( computed ) { - ret = computedStyle[ name ]; + ret = computed[ name ]; if ( ret === "" && !jQuery.contains( elem.ownerDocument.documentElement, elem ) ) { ret = jQuery.style( elem, name ); } @@ -293,7 +295,7 @@ if ( document.defaultView && document.defaultView.getComputedStyle ) { if ( !jQuery.support.pixelMargin && rmargin.test( name ) && rnumnonpx.test( ret ) ) { width = style.width; style.width = ret; - ret = computedStyle.width; + ret = computed.width; style.width = width; } } diff --git a/src/support.js b/src/support.js index 06170a39b..334175ff6 100644 --- a/src/support.js +++ b/src/support.js @@ -210,6 +210,11 @@ jQuery.support = (function() { div.style.cssText = "box-sizing:border-box;-moz-box-sizing:border-box;-webkit-box-sizing:border-box;padding:1px;border:1px;display:block;width:4px;margin-top:1%;position:absolute;top:1%;"; support.boxSizing = ( div.offsetWidth === 4 ); support.doesNotIncludeMarginInBodyOffset = ( body.offsetTop !== 1 ); + + // NOTE: To any future maintainer, window.getComputedStyle was used here + // instead of getComputedStyle because it gave a better gzip size. + // The difference between window.getComputedStyle and getComputedStyle is + // 7 bytes if ( window.getComputedStyle ) { support.pixelMargin = ( window.getComputedStyle( div, null ) || {} ).marginTop !== "1%"; support.pixelPosition = ( window.getComputedStyle( div, null ) || {} ).top !== "1%"; -- 2.39.5