From f821fc9a70f5a8b95ea527781704d1a4f3a67e2c Mon Sep 17 00:00:00 2001 From: Dominik Stadler Date: Fri, 4 Apr 2014 07:26:53 +0000 Subject: [PATCH] Fix some Eclipse warnings git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1584544 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/poi/hssf/dev/BaseXLSIteratingTest.java | 3 ++- .../org/apache/poi/hssf/dev/TestBiffDrawingToXml.java | 2 +- src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java | 2 +- src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java | 2 +- src/testcases/org/apache/poi/hssf/dev/TestReSave.java | 2 +- src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java | 2 +- 6 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/testcases/org/apache/poi/hssf/dev/BaseXLSIteratingTest.java b/src/testcases/org/apache/poi/hssf/dev/BaseXLSIteratingTest.java index 8c700b5620..521b9ad679 100644 --- a/src/testcases/org/apache/poi/hssf/dev/BaseXLSIteratingTest.java +++ b/src/testcases/org/apache/poi/hssf/dev/BaseXLSIteratingTest.java @@ -58,7 +58,8 @@ public abstract class BaseXLSIteratingTest { List failed = new ArrayList(); String[] files = new File(dir).list(new FilenameFilter() { - public boolean accept(File arg0, String arg1) { + @Override + public boolean accept(File arg0, String arg1) { return arg1.toLowerCase().endsWith(".xls"); } }); diff --git a/src/testcases/org/apache/poi/hssf/dev/TestBiffDrawingToXml.java b/src/testcases/org/apache/poi/hssf/dev/TestBiffDrawingToXml.java index 09a311e86e..e141608959 100644 --- a/src/testcases/org/apache/poi/hssf/dev/TestBiffDrawingToXml.java +++ b/src/testcases/org/apache/poi/hssf/dev/TestBiffDrawingToXml.java @@ -33,7 +33,7 @@ public class TestBiffDrawingToXml extends BaseXLSIteratingTest { // EXCLUDED.add("XRefCalc.xls"); // EXCLUDED.add("43493.xls"); // EXCLUDED.add("51832.xls"); - }; + } @Override @Ignore("Not yet done, nearly all files fail with various errors, remove this method when done to use the one from the abstract base class!...") diff --git a/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java b/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java index 711215d18d..9083fbdf75 100644 --- a/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java +++ b/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java @@ -37,7 +37,7 @@ public class TestBiffViewer extends BaseXLSIteratingTest { SILENT_EXCLUDED.add("password.xls"); SILENT_EXCLUDED.add("46904.xls"); SILENT_EXCLUDED.add("xor-encryption-abc.xls"); // unsupported XOR-encryption - }; + } @Override void runOneFile(String dir, String file, List failed) throws IOException { diff --git a/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java b/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java index 1ceb55c552..8683b78dcf 100644 --- a/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java +++ b/src/testcases/org/apache/poi/hssf/dev/TestFormulaViewer.java @@ -32,7 +32,7 @@ public class TestFormulaViewer extends BaseXLSIteratingTest { // EXCLUDED.add("BOOK_in_capitals.xls"); // EXCLUDED.add("46904.xls"); // EXCLUDED.add("OddStyleRecord.xls"); - }; + } @Override @Ignore("Not yet done, nearly all files fail with various errors, remove this method when done to use the one from the abstract base class!...") diff --git a/src/testcases/org/apache/poi/hssf/dev/TestReSave.java b/src/testcases/org/apache/poi/hssf/dev/TestReSave.java index 36a6de4eb9..cc124f449a 100644 --- a/src/testcases/org/apache/poi/hssf/dev/TestReSave.java +++ b/src/testcases/org/apache/poi/hssf/dev/TestReSave.java @@ -37,7 +37,7 @@ public class TestReSave extends BaseXLSIteratingTest { SILENT_EXCLUDED.add("43493.xls"); // HSSFWorkbook cannot open it as well SILENT_EXCLUDED.add("46904.xls"); SILENT_EXCLUDED.add("51832.xls"); // password - }; + } @Override void runOneFile(String dir, String file, List failed) throws Exception { diff --git a/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java b/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java index 58deca9197..c74816fd1e 100644 --- a/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java +++ b/src/testcases/org/apache/poi/hssf/dev/TestRecordLister.java @@ -29,7 +29,7 @@ public class TestRecordLister extends BaseXLSIteratingTest { // these are likely ok to fail SILENT_EXCLUDED.add("46904.xls"); - }; + } @Override void runOneFile(String dir, String file, List failed) throws IOException { -- 2.39.5