From fa4e58413d81026bce22445882d1379a4f65929b Mon Sep 17 00:00:00 2001
From: Wouter Admiraal <wouter.admiraal@sonarsource.com>
Date: Mon, 22 Feb 2021 12:30:21 +0100
Subject: [PATCH] SONAR-14483 Don't show new code filter on issues page for
 portfolios

---
 .../apps/issues/sidebar/CreationDateFacet.tsx |  3 +-
 .../__tests__/CreationDateFacet-test.tsx      |  4 +
 .../CreationDateFacet-test.tsx.snap           | 74 +++++++++++++++++++
 3 files changed, 80 insertions(+), 1 deletion(-)

diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.tsx b/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.tsx
index 4c7b00194a7..b05c71c38d3 100644
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.tsx
@@ -34,6 +34,7 @@ import DateRangeInput from '../../../components/controls/DateRangeInput';
 import FacetBox from '../../../components/facet/FacetBox';
 import FacetHeader from '../../../components/facet/FacetHeader';
 import FacetItem from '../../../components/facet/FacetItem';
+import { isPortfolioLike } from '../../../types/component';
 import { Query } from '../utils';
 
 interface Props {
@@ -229,7 +230,7 @@ export class CreationDateFacet extends React.PureComponent<Props & InjectedIntlP
           tooltip={translate('issues.facet.createdAt.all')}
           value=""
         />
-        {component ? (
+        {component && !isPortfolioLike(component.qualifier) ? (
           <FacetItem
             active={sinceLeakPeriod}
             name={translate('issues.new_code')}
diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/CreationDateFacet-test.tsx b/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/CreationDateFacet-test.tsx
index ee3978c0934..a03b532f38f 100644
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/CreationDateFacet-test.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/CreationDateFacet-test.tsx
@@ -21,6 +21,7 @@ import { shallow } from 'enzyme';
 import * as React from 'react';
 import { InjectedIntlProps } from 'react-intl';
 import { mockComponent } from '../../../../helpers/testMocks';
+import { ComponentQualifier } from '../../../../types/component';
 import { CreationDateFacet } from '../CreationDateFacet';
 
 it('should render correctly', () => {
@@ -40,6 +41,9 @@ it('should render correctly', () => {
     })
   ).toMatchSnapshot('created after timestamp');
   expect(shallowRender({ component: mockComponent() })).toMatchSnapshot('project');
+  expect(
+    shallowRender({ component: mockComponent({ qualifier: ComponentQualifier.Portfolio }) })
+  ).toMatchSnapshot('portfolio');
 });
 
 it.each([
diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/__snapshots__/CreationDateFacet-test.tsx.snap b/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/__snapshots__/CreationDateFacet-test.tsx.snap
index e073a3a2358..d3936e2f771 100644
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/__snapshots__/CreationDateFacet-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/__snapshots__/CreationDateFacet-test.tsx.snap
@@ -357,6 +357,80 @@ exports[`should render correctly: created at 1`] = `
 </FacetBox>
 `;
 
+exports[`should render correctly: portfolio 1`] = `
+<FacetBox
+  property="createdAt"
+>
+  <FacetHeader
+    fetching={false}
+    name="issues.facet.createdAt"
+    onClear={[Function]}
+    onClick={[Function]}
+    open={true}
+    values={Array []}
+  />
+  <div>
+    <div
+      className="search-navigator-date-facet-selection"
+    >
+      <DateRangeInput
+        onChange={[Function]}
+        value={
+          Object {
+            "from": undefined,
+            "to": undefined,
+          }
+        }
+      />
+    </div>
+    <div
+      className="spacer-top issues-predefined-periods"
+    >
+      <FacetItem
+        active={true}
+        disabled={false}
+        halfWidth={false}
+        loading={false}
+        name="issues.facet.createdAt.all"
+        onClick={[Function]}
+        tooltip="issues.facet.createdAt.all"
+        value=""
+      />
+      <FacetItem
+        active={false}
+        disabled={false}
+        halfWidth={false}
+        loading={false}
+        name="issues.facet.createdAt.last_week"
+        onClick={[Function]}
+        tooltip="issues.facet.createdAt.last_week"
+        value="1w"
+      />
+      <FacetItem
+        active={false}
+        disabled={false}
+        halfWidth={false}
+        loading={false}
+        name="issues.facet.createdAt.last_month"
+        onClick={[Function]}
+        tooltip="issues.facet.createdAt.last_month"
+        value="1m"
+      />
+      <FacetItem
+        active={false}
+        disabled={false}
+        halfWidth={false}
+        loading={false}
+        name="issues.facet.createdAt.last_year"
+        onClick={[Function]}
+        tooltip="issues.facet.createdAt.last_year"
+        value="1y"
+      />
+    </div>
+  </div>
+</FacetBox>
+`;
+
 exports[`should render correctly: project 1`] = `
 <FacetBox
   property="createdAt"
-- 
2.39.5