From fae006196acf91109f453aeac95acdcc5db6a24e Mon Sep 17 00:00:00 2001 From: Aurelien Poscia Date: Mon, 13 Mar 2023 15:57:23 +0100 Subject: [PATCH] SONAR-18525 fixed few code smells --- .../org/sonar/server/user/ws/UpdateIdentityProviderAction.java | 3 ++- .../main/java/org/sonar/server/usergroups/ws/GroupService.java | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/user/ws/UpdateIdentityProviderAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/user/ws/UpdateIdentityProviderAction.java index f38c851733b..e4d4f89e95d 100644 --- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/user/ws/UpdateIdentityProviderAction.java +++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/user/ws/UpdateIdentityProviderAction.java @@ -57,7 +57,8 @@ public class UpdateIdentityProviderAction implements UsersWsAction { private final UserSession userSession; private final ManagedInstanceChecker managedInstanceChecker; - public UpdateIdentityProviderAction(DbClient dbClient, IdentityProviderRepository identityProviderRepository, UserUpdater userUpdater, UserSession userSession, ManagedInstanceChecker managedInstanceChecker) { + public UpdateIdentityProviderAction(DbClient dbClient, IdentityProviderRepository identityProviderRepository, + UserUpdater userUpdater, UserSession userSession, ManagedInstanceChecker managedInstanceChecker) { this.dbClient = dbClient; this.identityProviderRepository = identityProviderRepository; this.userUpdater = userUpdater; diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/usergroups/ws/GroupService.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/usergroups/ws/GroupService.java index d8a9cbe68dc..bf57fe9fc07 100644 --- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/usergroups/ws/GroupService.java +++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/usergroups/ws/GroupService.java @@ -20,7 +20,6 @@ package org.sonar.server.usergroups.ws; import java.util.Optional; -import java.util.Set; import javax.annotation.Nullable; import org.sonar.api.security.DefaultGroups; import org.sonar.api.server.ServerSide; @@ -74,7 +73,6 @@ public class GroupService { return updateDescription(dbSession, withUpdatedName, newDescription); } - public GroupDto createGroup(DbSession dbSession, String name, @Nullable String description) { validateGroupName(name); checkNameDoesNotExist(dbSession, name); -- 2.39.5