From fc99811d0a4935eda1c7ea3d94ae1b50b8cc4b8c Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Mon, 19 Nov 2018 19:25:13 +0100 Subject: [PATCH] Clear link to avoid downloads Signed-off-by: Roeland Jago Douma --- apps/files_sharing/js/public.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/files_sharing/js/public.js b/apps/files_sharing/js/public.js index 812da7ca5cb..57001c495d3 100644 --- a/apps/files_sharing/js/public.js +++ b/apps/files_sharing/js/public.js @@ -205,10 +205,10 @@ OCA.Sharing.PublicApp = { var type = this.fileActions.getCurrentType(); var permissions = this.fileActions.getCurrentPermissions(); var action = this.fileActions.getDefault(mime, type, permissions); - if (action) { - // remove link href if there is a default action configured (disables downloading when trying to open in a new tab) - $tr.find('a.name').attr('href', '#'); - } + + // Remove the link. This means that files without a default action fail hard + $tr.find('a.name').attr('href', '#'); + delete this.fileActions.actions.all.Download; } return $tr; -- 2.39.5