From fcea1fe496a6b4d29285d731ae71b3b7a01ad13f Mon Sep 17 00:00:00 2001 From: Ivan Frade Date: Thu, 9 Nov 2023 14:45:32 -0800 Subject: [PATCH] CommitGraphWriter: Remove unnecesary progress update call Change [1] reduced the scope of the "writing commit graph" monitoring task. This left some monitor#update() calls out of any task. When out of a task, the #update call is a noop. Delete this update calls as they are noops and misleading. The affected chunks are usually small and quick to write, so probably they don't need progress monitoring. [1] https://git.eclipse.org/r/c/jgit/jgit/+/205339 Change-Id: I74d94e6e44e58816937dc8a84e5a10b340e54e0b --- .../jgit/internal/storage/commitgraph/CommitGraphWriter.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java index b697edb60e..1f1c35ac19 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java @@ -261,7 +261,6 @@ public class CommitGraphWriter { for (int n : fanout) { NB.encodeInt32(tmp, 0, n); out.write(tmp, 0, 4); - out.getWriteMonitor().update(1); } } @@ -272,7 +271,6 @@ public class CommitGraphWriter { for (RevCommit c : graphCommits) { c.copyRawTo(tmp, 0); out.write(tmp, 0, hashsz); - out.getWriteMonitor().update(1); } } @@ -470,7 +468,6 @@ public class CommitGraphWriter { } NB.encodeInt32(tmp, 0, edgeValue); out.write(tmp); - out.getWriteMonitor().update(1); } } } -- 2.39.5