From fe7e58f64aa34af7c61d8bb3dfc6eb21df3e62aa Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Lievremont Date: Thu, 30 Jan 2014 11:02:52 +0100 Subject: [PATCH] SONAR-4959 Validate text manual measure is not empty --- .../src/main/webapp/WEB-INF/app/models/manual_measure.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sonar-server/src/main/webapp/WEB-INF/app/models/manual_measure.rb b/sonar-server/src/main/webapp/WEB-INF/app/models/manual_measure.rb index 718e0326b83..03a9862d3f1 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/models/manual_measure.rb +++ b/sonar-server/src/main/webapp/WEB-INF/app/models/manual_measure.rb @@ -136,6 +136,8 @@ class ManualMeasure < ActiveRecord::Base errors.add('value', "Value must be OK, WARN or ERROR") if !['OK', 'WARN', 'ERROR'].include?(raw_value) write_attribute("value", Sonar::RulePriority.id(raw_value)) write_attribute("text_value", raw_value) + when Metric::VALUE_TYPE_STRING + errors.add('value', "A text value must be provided") if value_before_type_cast.nil? || value_before_type_cast == '' end end end -- 2.39.5