From 14f99dc29d67fa4d2cb227ab906c5c8379499f6b Mon Sep 17 00:00:00 2001 From: "Shawn O. Pearce" Date: Tue, 15 Feb 2011 09:40:16 -0800 Subject: [PATCH] PackWriter: Try for accurate delta reuse on cached pack If a cached pack is used, it might know how many deltas are contained within it. Record that count as part of our reusedDeltas field for the stats line we show clients. Change-Id: I1c61fb817305a95eeac654cccf132cba20b2339c Signed-off-by: Shawn O. Pearce --- .../eclipse/jgit/storage/pack/CachedPack.java | 21 +++++++++++++++++++ .../eclipse/jgit/storage/pack/PackWriter.java | 1 + 2 files changed, 22 insertions(+) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/CachedPack.java b/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/CachedPack.java index c369e653ef..580fa78416 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/CachedPack.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/CachedPack.java @@ -71,6 +71,27 @@ public abstract class CachedPack { */ public abstract long getObjectCount() throws IOException; + /** + * Get the number of delta objects stored in this pack. + *

+ * This is an optional method, not every cached pack storage system knows + * the precise number of deltas stored within the pack. This number must be + * smaller than {@link #getObjectCount()} as deltas are not supposed to span + * across pack files. + *

+ * This method must be fast, if the only way to determine delta counts is to + * scan the pack file's contents one object at a time, implementors should + * return 0 and avoid the high cost of the scan. + * + * @return the number of deltas; 0 if the number is not known or there are + * no deltas. + * @throws IOException + * if the delta count cannot be read. + */ + public long getDeltaCount() throws IOException { + return 0; + } + /** * Determine if the pack contains the requested objects. * diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/PackWriter.java b/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/PackWriter.java index 3b1016926f..b8b2767677 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/PackWriter.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/storage/pack/PackWriter.java @@ -588,6 +588,7 @@ public class PackWriter { for (CachedPack pack : cachedPacks) { stats.reusedObjects += pack.getObjectCount(); + stats.reusedDeltas += pack.getDeltaCount(); reuseSupport.copyPackAsIs(out, pack); } writeChecksum(out); -- 2.39.5