From 6511a066c124a8c336bd299c6200c99fe0c0b08c Mon Sep 17 00:00:00 2001
From: =?utf8?q?Leif=20=C3=85strand?= <leif@vaadin.com>
Date: Fri, 14 Dec 2012 17:04:26 +0200
Subject: [PATCH] Support null values in legacy messages (#9254)

Change-Id: I8a7bc1f52ffed7acc2de03c6d17cdff7f640ddf2
---
 server/src/com/vaadin/server/JsonCodec.java   |  4 +++
 .../com/vaadin/server/JSONSerializerTest.java | 27 +++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/server/src/com/vaadin/server/JsonCodec.java b/server/src/com/vaadin/server/JsonCodec.java
index 89ef060ef0..f7cbe79fdb 100644
--- a/server/src/com/vaadin/server/JsonCodec.java
+++ b/server/src/com/vaadin/server/JsonCodec.java
@@ -185,6 +185,7 @@ public class JsonCodec implements Serializable {
         registerType(HashMap.class, JsonConstants.VTYPE_MAP);
         registerType(List.class, JsonConstants.VTYPE_LIST);
         registerType(Set.class, JsonConstants.VTYPE_SET);
+        registerType(Void.class, JsonConstants.VTYPE_NULL);
     }
 
     private static void registerType(Class<?> type, String transportType) {
@@ -325,6 +326,9 @@ public class JsonCodec implements Serializable {
 
         if (encodedJsonValue == JSONObject.NULL) {
             return null;
+        } else if (targetType == Void.class) {
+            throw new JSONException(
+                    "Something other than null was encoded for a null type");
         }
 
         // UidlValue
diff --git a/server/tests/src/com/vaadin/server/JSONSerializerTest.java b/server/tests/src/com/vaadin/server/JSONSerializerTest.java
index fc02c13781..981f74a2a4 100644
--- a/server/tests/src/com/vaadin/server/JSONSerializerTest.java
+++ b/server/tests/src/com/vaadin/server/JSONSerializerTest.java
@@ -16,13 +16,20 @@ package com.vaadin.server;
  * the License.
  */
 import java.lang.reflect.Type;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Map;
 
+import junit.framework.AssertionFailedError;
 import junit.framework.TestCase;
 
+import org.json.JSONArray;
+import org.json.JSONException;
+import org.json.JSONObject;
+
 import com.vaadin.server.JsonCodec.BeanProperty;
+import com.vaadin.shared.communication.UidlValue;
 import com.vaadin.shared.ui.splitpanel.AbstractSplitPanelState;
 
 /**
@@ -72,6 +79,26 @@ public class JSONSerializerTest extends TestCase {
         ensureDecodedCorrectly(stateToStringMap, encodedMap, mapType);
     }
 
+    public void testNullLegacyValue() throws JSONException {
+        JSONArray inputArray = new JSONArray(
+                Arrays.asList("n", JSONObject.NULL));
+        UidlValue decodedObject = (UidlValue) JsonCodec.decodeInternalType(
+                UidlValue.class, true, inputArray, null);
+        assertNull(decodedObject.getValue());
+    }
+
+    public void testNullTypeOtherValue() {
+        try {
+            JSONArray inputArray = new JSONArray(Arrays.asList("n", "a"));
+            UidlValue decodedObject = (UidlValue) JsonCodec.decodeInternalType(
+                    UidlValue.class, true, inputArray, null);
+
+            throw new AssertionFailedError("No JSONException thrown");
+        } catch (JSONException e) {
+            // Should throw exception
+        }
+    }
+
     private void ensureDecodedCorrectly(Object original, Object encoded,
             Type type) throws Exception {
         Object serverSideDecoded = JsonCodec.decodeInternalOrCustomType(type,
-- 
2.39.5