From 65d6bb073aba072a17c5324a48972b02861bf4e2 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Mon, 1 Oct 2018 11:18:45 +0900 Subject: [PATCH] Override int read(byte[], int, int) on test instances of InputStream This probably doesn't provide any benefit for the tests, but gets rid of a warning from Error Prone. See https://errorprone.info/bugpattern/InputStreamSlowMultibyteRead Change-Id: I584d2e0d18475fad38747b688af6301c423f54a7 Signed-off-by: David Pursehouse --- .../tst/org/eclipse/jgit/lib/ObjectLoaderTest.java | 6 ++++++ .../tst/org/eclipse/jgit/util/io/UnionInputStreamTest.java | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/ObjectLoaderTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/ObjectLoaderTest.java index 83e61d9ab4..055e66ed81 100644 --- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/ObjectLoaderTest.java +++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/ObjectLoaderTest.java @@ -260,6 +260,12 @@ public class ObjectLoaderTest { fail("never should have reached read"); return -1; } + + @Override + public int read(byte b[], int off, int len) { + fail("never should have reached read"); + return -1; + } }; } }; diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/io/UnionInputStreamTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/io/UnionInputStreamTest.java index b824fae9fd..0bfa772bed 100644 --- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/io/UnionInputStreamTest.java +++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/io/UnionInputStreamTest.java @@ -259,6 +259,11 @@ public class UnionInputStreamTest { public int read() throws IOException { throw new IOException("Expected"); } + + @Override + public int read(byte b[], int off, int len) throws IOException { + throw new IOException("Expected"); + } }; @SuppressWarnings("resource" /* java 7 */) final UnionInputStream u = new UnionInputStream( -- 2.39.5