From 9303390b66ffc50fc83ba7e6c251c065e88db227 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 21 Jul 2020 21:25:18 +0200 Subject: [PATCH] Hide share link menu before copying the share link in acceptance tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The (old) Firefox version used in the acceptance tests does not properly render the share link menu. As the menu is taller than it should sometimes it covers the copy link button, so it is not possible to click it without hiding the share link menu. Moreover, in those cases the share menu button is also covered by the share menu, so the menu needs to be closed by pressing the "Esc" key. Signed-off-by: Daniel Calviño Sánchez --- .../features/bootstrap/FilesAppSharingContext.php | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/acceptance/features/bootstrap/FilesAppSharingContext.php b/tests/acceptance/features/bootstrap/FilesAppSharingContext.php index 80d21a0faf9..9f02ab5cab5 100644 --- a/tests/acceptance/features/bootstrap/FilesAppSharingContext.php +++ b/tests/acceptance/features/bootstrap/FilesAppSharingContext.php @@ -328,6 +328,17 @@ class FilesAppSharingContext implements Context, ActorAwareInterface { * @Given I write down the shared link */ public function iWriteDownTheSharedLink() { + // Close the share link menu if it is open to ensure that it does not + // cover the copy link button. + if (!WaitFor::elementToBeEventuallyNotShown( + $this->actor, + self::shareLinkMenu(), + $timeout = 2 * $this->actor->getFindTimeoutMultiplier())) { + // It may not be possible to click on the menu button (due to the + // menu itself covering it), so "Esc" key is pressed instead. + $this->actor->find(self::shareLinkMenu(), 2)->getWrappedElement()->keyPress(27); + } + $this->actor->find(self::copyLinkButton(), 10)->click(); // Clicking on the menu item copies the link to the clipboard, but it is -- 2.39.5