From 16d83ab30a60c2a6a4cd71c1127dbc8dece7e136 Mon Sep 17 00:00:00 2001
From: Morris Jobke <hey@morrisjobke.de>
Date: Thu, 13 Aug 2020 21:50:06 +0200
Subject: [PATCH] Remove getLastJob from IJobList

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
---
 lib/private/BackgroundJob/JobList.php    | 12 ------------
 lib/public/BackgroundJob/IJobList.php    | 11 -----------
 tests/lib/BackgroundJob/DummyJobList.php |  9 ---------
 tests/lib/BackgroundJob/JobListTest.php  |  9 ---------
 4 files changed, 41 deletions(-)

diff --git a/lib/private/BackgroundJob/JobList.php b/lib/private/BackgroundJob/JobList.php
index 1adecb5b32d..d9d80374cfd 100644
--- a/lib/private/BackgroundJob/JobList.php
+++ b/lib/private/BackgroundJob/JobList.php
@@ -310,18 +310,6 @@ class JobList implements IJobList {
 		$query->execute();
 	}
 
-	/**
-	 * get the id of the last ran job
-	 *
-	 * @return int
-	 * @deprecated 9.1.0 - The functionality behind the value is deprecated, it
-	 *    only tells you which job finished last, but since we now allow multiple
-	 *    executors to run in parallel, it's not used to calculate the next job.
-	 */
-	public function getLastJob() {
-		return (int) $this->config->getAppValue('backgroundjob', 'lastjob', 0);
-	}
-
 	/**
 	 * set the lastRun of $job to now
 	 *
diff --git a/lib/public/BackgroundJob/IJobList.php b/lib/public/BackgroundJob/IJobList.php
index cf04cb21f48..eb8a2c5e3dc 100644
--- a/lib/public/BackgroundJob/IJobList.php
+++ b/lib/public/BackgroundJob/IJobList.php
@@ -115,17 +115,6 @@ interface IJobList {
 	 */
 	public function unlockJob(IJob $job);
 
-	/**
-	 * get the id of the last ran job
-	 *
-	 * @return int
-	 * @since 7.0.0
-	 * @deprecated 9.1.0 - The functionality behind the value is deprecated, it
-	 *    only tells you which job finished last, but since we now allow multiple
-	 *    executors to run in parallel, it's not used to calculate the next job.
-	 */
-	public function getLastJob();
-
 	/**
 	 * set the lastRun of $job to now
 	 *
diff --git a/tests/lib/BackgroundJob/DummyJobList.php b/tests/lib/BackgroundJob/DummyJobList.php
index 529e93e960f..452b9bb98ed 100644
--- a/tests/lib/BackgroundJob/DummyJobList.php
+++ b/tests/lib/BackgroundJob/DummyJobList.php
@@ -117,15 +117,6 @@ class DummyJobList extends \OC\BackgroundJob\JobList {
 		return null;
 	}
 
-	/**
-	 * get the id of the last ran job
-	 *
-	 * @return int
-	 */
-	public function getLastJob() {
-		return $this->last;
-	}
-
 	/**
 	 * set the lastRun of $job to now
 	 *
diff --git a/tests/lib/BackgroundJob/JobListTest.php b/tests/lib/BackgroundJob/JobListTest.php
index 20ba1e50016..736d670ed20 100644
--- a/tests/lib/BackgroundJob/JobListTest.php
+++ b/tests/lib/BackgroundJob/JobListTest.php
@@ -146,15 +146,6 @@ class JobListTest extends TestCase {
 		$this->assertFalse($this->instance->has($job, 10));
 	}
 
-	public function testGetLastJob() {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('backgroundjob', 'lastjob', 0)
-			->willReturn(15);
-
-		$this->assertEquals(15, $this->instance->getLastJob());
-	}
-
 	protected function createTempJob($class, $argument, $reservedTime = 0, $lastChecked = 0) {
 		if ($lastChecked === 0) {
 			$lastChecked = time();
-- 
2.39.5