From 6c78e87993ddadfcf90ca5b752264a1baf626264 Mon Sep 17 00:00:00 2001
From: =?utf8?q?S=C3=A9bastien=20Lesaint?=
 <sebastien.lesaint@sonarsource.com>
Date: Thu, 23 Nov 2017 17:29:08 +0100
Subject: [PATCH] fix logback configuration in UTs to drastically reduce build
 verbosity

---
 server/sonar-db-core/pom.xml                  |  5 +++
 .../test/java/org/sonar/db/CoreTestDb.java    |  2 +-
 server/sonar-db-dao/pom.xml                   |  5 +++
 .../src/test/resources/logback-test.xml       | 33 +++++++++++++++++++
 .../java/org/sonar/process/LoggingRule.java   |  6 ++++
 .../src/test/resources/logback-test.xml       | 22 +++++++++++++
 .../org/sonar/process/logback-test.xml        | 14 +++++---
 server/sonar-server/pom.xml                   |  5 +++
 .../src/test/resources/logback-test.xml       | 26 +++++++++++++++
 sonar-plugin-api/pom.xml                      |  5 +++
 .../src/test/resources/logback-test.xml       | 22 +++++++++++++
 .../src/test/resources/logback-test.xml       |  3 ++
 tests/src/test/resources/logback-test.xml     |  8 +++++
 13 files changed, 151 insertions(+), 5 deletions(-)
 create mode 100644 server/sonar-db-dao/src/test/resources/logback-test.xml
 create mode 100644 server/sonar-process/src/test/resources/logback-test.xml
 create mode 100644 server/sonar-server/src/test/resources/logback-test.xml
 create mode 100644 sonar-plugin-api/src/test/resources/logback-test.xml

diff --git a/server/sonar-db-core/pom.xml b/server/sonar-db-core/pom.xml
index 5383b1bbec6..435c2c271a0 100644
--- a/server/sonar-db-core/pom.xml
+++ b/server/sonar-db-core/pom.xml
@@ -134,6 +134,11 @@
             <goals>
               <goal>test-jar</goal>
             </goals>
+            <configuration>
+              <excludes>
+                <exclude>logback-test.xml</exclude>
+              </excludes>
+            </configuration>
           </execution>
         </executions>
       </plugin>
diff --git a/server/sonar-db-core/src/test/java/org/sonar/db/CoreTestDb.java b/server/sonar-db-core/src/test/java/org/sonar/db/CoreTestDb.java
index 8476c8ef8c9..3cfdedd55ce 100644
--- a/server/sonar-db-core/src/test/java/org/sonar/db/CoreTestDb.java
+++ b/server/sonar-db-core/src/test/java/org/sonar/db/CoreTestDb.java
@@ -94,7 +94,7 @@ class CoreTestDb {
         }
       }
       isDefault = (schemaPath == null);
-      LOG.info("Test Database: " + db);
+      LOG.debug("Test Database: " + db);
 
       commands = DatabaseCommands.forDialect(db.getDialect());
       tester = new DataSourceDatabaseTester(db.getDataSource(), commands.useLoginAsSchema() ? login : null);
diff --git a/server/sonar-db-dao/pom.xml b/server/sonar-db-dao/pom.xml
index f76bb60e10b..1653910359f 100644
--- a/server/sonar-db-dao/pom.xml
+++ b/server/sonar-db-dao/pom.xml
@@ -93,6 +93,11 @@
             <goals>
               <goal>test-jar</goal>
             </goals>
+            <configuration>
+              <excludes>
+                <exclude>logback-test.xml</exclude>
+              </excludes>
+            </configuration>
           </execution>
         </executions>
       </plugin>
diff --git a/server/sonar-db-dao/src/test/resources/logback-test.xml b/server/sonar-db-dao/src/test/resources/logback-test.xml
new file mode 100644
index 00000000000..4b0ff6da04b
--- /dev/null
+++ b/server/sonar-db-dao/src/test/resources/logback-test.xml
@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+
+<configuration>
+
+  <appender name="STDOUT"
+            class="ch.qos.logback.core.ConsoleAppender">
+    <encoder>
+      <pattern>
+        %d{HH:mm:ss.SSS} %-5level %logger{36} - %msg%n
+      </pattern>
+    </encoder>
+  </appender>
+
+  <logger name="org.dbunit">
+    <level value="WARN"/>
+  </logger>
+
+  <!-- set to level DEBUG to log SQL requests executed by MyBatis -->
+  <logger name="java.sql">
+    <level value="WARN"/>
+  </logger>
+
+  <!-- required for DryRunDatabaseFactoryTest -->
+  <logger name="org.elasticsearch">
+    <level value="WARN"/>
+  </logger>
+
+  <root>
+    <level value="INFO"/>
+    <appender-ref ref="STDOUT"/>
+  </root>
+
+</configuration>
diff --git a/server/sonar-process/src/test/java/org/sonar/process/LoggingRule.java b/server/sonar-process/src/test/java/org/sonar/process/LoggingRule.java
index 3246e0c4527..1b2289db409 100644
--- a/server/sonar-process/src/test/java/org/sonar/process/LoggingRule.java
+++ b/server/sonar-process/src/test/java/org/sonar/process/LoggingRule.java
@@ -21,6 +21,7 @@ package org.sonar.process;
 
 import ch.qos.logback.classic.Logger;
 import ch.qos.logback.classic.spi.LoggingEvent;
+import ch.qos.logback.core.joran.spi.JoranException;
 import java.util.List;
 import java.util.stream.Collectors;
 import org.junit.rules.ExternalResource;
@@ -47,6 +48,11 @@ public class LoggingRule extends ExternalResource {
   protected void after() {
     TestLogbackAppender.events.clear();
     setLevel(Level.INFO);
+    try {
+      new LogbackHelper().resetFromXml("/logback-test.xml");
+    } catch (JoranException e) {
+      e.printStackTrace();
+    }
   }
 
   public LoggingRule setLevel(Level level) {
diff --git a/server/sonar-process/src/test/resources/logback-test.xml b/server/sonar-process/src/test/resources/logback-test.xml
new file mode 100644
index 00000000000..7cfba2985f6
--- /dev/null
+++ b/server/sonar-process/src/test/resources/logback-test.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<configuration debug="false">
+  <contextListener class="ch.qos.logback.classic.jul.LevelChangePropagator"/>
+
+  <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
+    <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+      <pattern>
+        %d{yyyy.MM.dd HH:mm:ss} %-5level %msg%n
+      </pattern>
+    </encoder>
+  </appender>
+
+  <root>
+    <level value="INFO"/>
+    <appender-ref ref="CONSOLE"/>
+  </root>
+
+  <logger name="ch.qos.logback">
+    <level value="WARN"/>
+  </logger>
+
+</configuration>
diff --git a/server/sonar-process/src/test/resources/org/sonar/process/logback-test.xml b/server/sonar-process/src/test/resources/org/sonar/process/logback-test.xml
index 72521000bab..abef1709f75 100644
--- a/server/sonar-process/src/test/resources/org/sonar/process/logback-test.xml
+++ b/server/sonar-process/src/test/resources/org/sonar/process/logback-test.xml
@@ -1,7 +1,8 @@
 <?xml version="1.0" encoding="UTF-8" ?>
-<configuration debug="true">
+<configuration debug="false">
+  <contextListener class="ch.qos.logback.classic.jul.LevelChangePropagator"/>
 
-  <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+  <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
     <encoder>
       <pattern>%d{HH:mm:ss.SSS} %-5level - %msg%n</pattern>
     </encoder>
@@ -13,8 +14,13 @@
     </encoder>
   </appender>
 
-  <root level="INFO">
-    <appender-ref ref="STDOUD" />
+  <root>
+    <level value="INFO"/>
+    <appender-ref ref="CONSOLE" />
     <appender-ref ref="TESTING" />
   </root>
+
+  <logger name="ch.qos.logback">
+    <level value="WARN"/>
+  </logger>
 </configuration>
diff --git a/server/sonar-server/pom.xml b/server/sonar-server/pom.xml
index 35f54740f22..530cfc2f1ec 100644
--- a/server/sonar-server/pom.xml
+++ b/server/sonar-server/pom.xml
@@ -303,6 +303,11 @@
             <goals>
               <goal>test-jar</goal>
             </goals>
+            <configuration>
+              <excludes>
+                <exclude>logback-test.xml</exclude>
+              </excludes>
+            </configuration>
           </execution>
         </executions>
         <configuration>
diff --git a/server/sonar-server/src/test/resources/logback-test.xml b/server/sonar-server/src/test/resources/logback-test.xml
new file mode 100644
index 00000000000..3e34b0f9fc8
--- /dev/null
+++ b/server/sonar-server/src/test/resources/logback-test.xml
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<configuration debug="false">
+  <contextListener class="ch.qos.logback.classic.jul.LevelChangePropagator"/>
+
+  <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
+    <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+      <pattern>
+        %d{yyyy.MM.dd HH:mm:ss} %-5level %msg%n
+      </pattern>
+    </encoder>
+  </appender>
+
+  <root>
+    <level value="INFO"/>
+    <appender-ref ref="CONSOLE"/>
+  </root>
+
+  <logger name="ch.qos.logback">
+    <level value="WARN"/>
+  </logger>
+
+  <logger name="okhttp3.mockwebserver">
+    <level value="WARN"/>
+  </logger>
+
+</configuration>
diff --git a/sonar-plugin-api/pom.xml b/sonar-plugin-api/pom.xml
index bb2965c9caf..a49ee6b5e0f 100644
--- a/sonar-plugin-api/pom.xml
+++ b/sonar-plugin-api/pom.xml
@@ -227,6 +227,11 @@
             <goals>
               <goal>test-jar</goal>
             </goals>
+            <configuration>
+              <excludes>
+                <exclude>logback-test.xml</exclude>
+              </excludes>
+            </configuration>
           </execution>
         </executions>
       </plugin>
diff --git a/sonar-plugin-api/src/test/resources/logback-test.xml b/sonar-plugin-api/src/test/resources/logback-test.xml
new file mode 100644
index 00000000000..7cfba2985f6
--- /dev/null
+++ b/sonar-plugin-api/src/test/resources/logback-test.xml
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<configuration debug="false">
+  <contextListener class="ch.qos.logback.classic.jul.LevelChangePropagator"/>
+
+  <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
+    <encoder class="ch.qos.logback.classic.encoder.PatternLayoutEncoder">
+      <pattern>
+        %d{yyyy.MM.dd HH:mm:ss} %-5level %msg%n
+      </pattern>
+    </encoder>
+  </appender>
+
+  <root>
+    <level value="INFO"/>
+    <appender-ref ref="CONSOLE"/>
+  </root>
+
+  <logger name="ch.qos.logback">
+    <level value="WARN"/>
+  </logger>
+
+</configuration>
diff --git a/sonar-scanner-engine/src/test/resources/logback-test.xml b/sonar-scanner-engine/src/test/resources/logback-test.xml
index da6be3344a2..0693729e99c 100644
--- a/sonar-scanner-engine/src/test/resources/logback-test.xml
+++ b/sonar-scanner-engine/src/test/resources/logback-test.xml
@@ -33,6 +33,9 @@
   <logger name="PERSISTIT">
     <level value="WARN"/>
   </logger>
+  <logger name="ch.qos.logback">
+    <level value="WARN"/>
+  </logger>
 
   <root>
     <level value="INFO"/>
diff --git a/tests/src/test/resources/logback-test.xml b/tests/src/test/resources/logback-test.xml
index 599faa969f0..88bfffc9f14 100644
--- a/tests/src/test/resources/logback-test.xml
+++ b/tests/src/test/resources/logback-test.xml
@@ -16,4 +16,12 @@
     <appender-ref ref="CONSOLE"/>
   </root>
 
+  <logger name="ch.qos.logback">
+    <level value="WARN"/>
+  </logger>
+
+  <logger name="okhttp3.mockwebserver">
+    <level value="WARN"/>
+  </logger>
+
 </configuration>
-- 
2.39.5