diff options
| author | Alexander Kriegisch <Alexander@Kriegisch.name> | 2021-04-16 15:30:36 +0700 |
|---|---|---|
| committer | Alexander Kriegisch <Alexander@Kriegisch.name> | 2021-04-17 00:14:55 +0700 |
| commit | 116406fbbc665f6ea6d8fccf150389d808751642 (patch) | |
| tree | 34e4a1c9e70faa9b1c3ea4e946e85aa8ca8728e1 /aspectjrt | |
| parent | 0e7ac59f24f449d6d54d31634075f9bffcb57588 (diff) | |
| download | aspectj-116406fbbc665f6ea6d8fccf150389d808751642.tar.gz aspectj-116406fbbc665f6ea6d8fccf150389d808751642.zip | |
Fix: make sure that source assemblies are attached to build
Previously I renamed the source assemblies from the uniform name
'sources' to something more individual like 'aspectjtools-sources', not
realising that the magic name 'sources' in combination with the default
configuration value 'appendAssemblyId=true' results in an artifact
classifier equal to the assembly ID, i.e. 'sources', which is exactly
what we need here, but not quite obvious. Therefore, I documented it
with comments in both the assemblies and the POMs.
Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
Diffstat (limited to 'aspectjrt')
| -rw-r--r-- | aspectjrt/aspectjrt-sources-assembly.xml | 3 | ||||
| -rw-r--r-- | aspectjrt/pom.xml | 6 |
2 files changed, 5 insertions, 4 deletions
diff --git a/aspectjrt/aspectjrt-sources-assembly.xml b/aspectjrt/aspectjrt-sources-assembly.xml index b4c13e2a9..fc030c3c2 100644 --- a/aspectjrt/aspectjrt-sources-assembly.xml +++ b/aspectjrt/aspectjrt-sources-assembly.xml @@ -2,7 +2,8 @@ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.1.0 http://maven.apache.org/xsd/assembly-2.1.0.xsd"> -<id>aspectjrt-sources</id> + <!-- Do not change this ID. It becomes the artifact classifier with appendAssemblyId=true. --> + <id>sources</id> <formats> <format>jar</format> diff --git a/aspectjrt/pom.xml b/aspectjrt/pom.xml index 341b83fd6..930ba02ca 100644 --- a/aspectjrt/pom.xml +++ b/aspectjrt/pom.xml @@ -99,14 +99,14 @@ </execution> <execution> - <id>aspectjrt-src-assembly</id> + <id>aspectjrt-sources-assembly</id> <phase>package</phase> <goals> <goal>single</goal> </goals> <configuration> - <classifier>sources</classifier> - <finalName>aspectjrt-${project.version}</finalName> + <!-- The assembly ID 'sources' becomes the artifact classifier, exactly what we want --> + <appendAssemblyId>true</appendAssemblyId> <archive> </archive> <descriptors> |