aboutsummaryrefslogtreecommitdiffstats
path: root/ajdoc/src
Commit message (Collapse)AuthorAgeFilesLines
* Add Java23 supportAndrew Clement2025-03-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The huge change with adopting Java23 is that 1.1 > 1.7 Java are now considered unsupported by Eclipse JDT, so the many thousands of tests we have that were specifying java versions lower than 1.8 were all failing with an unsupported version error. All those tests have had their versions bumped to 1.8.

That is why this commit includes so many changes. For example where we were specifying 1.5 - which was the case for many many generics/annotations tests, that is now 1.8. Also, some tests have been deleted because they make no sense now (verifying expected errors on Java 1.4 for example, errors that just can’t happen with minimum Java level 1.8). The biggest impact to tests was when bumping above 1.4 compliance suddenly there were 100s of adviceDidNotMatch messages. Some of these messages were actual indications of bad expectations in the test but many of them were just to-be-expected and were fixed either via an -Xlint:ignore option in the test spec or a SuppressAjWarnings in the test source.

One or two tests actually revealed real bugs that just didn’t surface with lower level java versions specified. A bare minimum of real Java 23 tests have been added just to get this sanity tested and committed. More would ideally be added. Other notable changes due to Eclipse JDT changes: org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/compiler/ast/*.java Changes in here because there are now more validations on the code generator methods we were calling. Now you can’t start manipulating variables without having declared them as proper local variables, so those extra calls to define them have been added.
 org.aspectj.ajdt.core/src/org/aspectj/org/eclipse/jdt/core/dom With needing to bump up the java versions, these classes had to be brought up to date with AST.JLS20 rather than only supporting versions 2/3. This was mostly copying patterns for the Eclipse classes.


* LangUtil: remove methods like 'is11VMOrGreater', 'is1dot5VMOrGreater'Alexander Kriegisch2024-02-196-22/+22
| | | | | | | | | | Replace them by a uniform method 'isVMGreaterOrEqual(double)', also overloaded for int. This gets rid of one 'AspectJ_JDK_Update' tag. One less place to check and update with each newly supported Java version. :-) Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Replace old by new AspectJ GitHub URLAlexander Kriegisch2024-02-081-1/+1
| | | | | | github.com/eclipse/org.aspectj -> github.com/eclipse-aspectj/aspectj Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Fix javadoc generation broken on JDK 20Alexander Kriegisch2023-06-243-7/+22
| | | | | | | | | | | | | Firstly, Javadoc 20 cannot handle source level 1.7 anymore, so I bumped it to 11, which hopefully will be around for another while. It also matches the ajc minimum of Java 11, i.e. ajdoc and ajc are synchronised in this regard now. Secondly, as of JDK 20, the javadoc tool renders HTML pages with section headers specific to the JVM default locale. The workaround is to set the locale to English before calling javadoc. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Remove redundant casts after generics updateAndrey Turbanov2022-04-121-2/+2
|
* Use StringBuilder/StringJoiner for concatenation String's in loopAndrey Turbanov2021-12-181-24/+29
|
* Replace more usages of StringBuffer with StringBuilderAndrey Turbanov2021-12-051-8/+8
|
* Replace uses of StringBuffer with StringBuilder.Andrey Turbanov2021-11-203-7/+7
| | | | StringBuffer is a legacy synchronized class. StringBuilder is a direct replacement to StringBuffer which generally have better performance.
* Fix minor indentation issues in org.aspectj.tools.ajdoc.MainAlexander Kriegisch2021-06-101-3/+3
| | | | Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Upgrade license from CPLv1/EPLv1 to EPLv2Alexander Kriegisch2021-06-0424-319/+319
| | | | | | | This was required by the Eclipse team as one precondition for the next release. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Revert "Always run javadoc using the ToolProvider API"Alexander Kriegisch2021-05-282-18/+48
| | | | | | | | | | | | | This reverts commit f70aeb5e, except for some commented-out parts of code and an unused method. I also simplified the code, e.g. with regard to exception handling, and did some more cosmetic stuff, but basically it is a revert. In order to make it compile on more recent JDKs which doe not have class com.sun.tools.javadoc.Main, I used Class.forName in the method being called on JDK 8 only. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* housekeepingAndy Clement2021-05-231-3/+3
|
* Clean up Maven dependencies using 'dependency:analyze' goalAlexander Kriegisch2021-04-121-11/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | Notably, this change involves a partial revert of @4a5660b3, because we are not using JUnit Jupiter yet but still JUnit 4 tests. See discussion under commit at https://github.com/eclipse/org.aspectj/commit/4a5660b3. Many other warnings - concerning both used undeclared and unused declared dependencies - were eliminated by adding or removing the corresponding dependencies from the POMs. Furthermore, I tried to make sure that some clearly test-scoped dependencies are now actually declared as such, so as to avoid unwanted transitivity bleeding into compile scope and maybe unwanted classes ending up in uber JARs via Maven Shade or Maven Assembly. TODO: I am not so sure why modules other than 'run-all-unit-tests' would depend on test JARs. I hope I broke nothing essential there. As of today, the other modules where I found '<type>test-jar</type>' dependencies are: - ajde - testing - testing-drivers - tests - weaver Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Add Java 16 Linux matcher variant to HtmlDecoratorAlexander Kriegisch2021-03-222-90/+121
| | | | | | | | | | | | | | | | | | | The Java 16 Javadoc generator has changed the HTML structure once again even compared to Java 15. I adjusted the matching in HtmlDecorator and also fixed CoverageTestCase. Most methods there I just made to work quickly, but method 'testInnerAspect()' I actually refactored. Some other methods could (probably should) be restructured in a similar fashion, but for now I just wanted to understand what the test does and see how much work it would be to refactor it. But finally, I just want to get the GitHub CI build running on Java 16. TODO: I did not check if the decorated HTML actually looks OK and am unsure if the tests cover that sufficiently, I never reviewed the tests. It would also be better to do regex matches instead of looking for variants of fixed strings or maybe even to operate on a DOM. But I am not in a mood to refactor that tonight. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Add diagnostic output to HtmlDecorator if AJ-Doc generation failsAlexander Kriegisch2021-03-212-0/+14
| | | | | | | | | | | | | | HtmlDecorator.decorateHTMLFile is where after Java version upgrades (i.e. also new Javadoc generator version) usually tests fail for the first time during builds because strings no longer match as expected. There now is this log message on stdOut: "Something unexpected went wrong in HtmlDecorator. Here is the full file causing the problem:" After that, a full HTML page is logged. I hope this helps me identify the new error on GitHub Linux Java 16, because the same test works on Windows and I have no idea how to remote-debug a GitHub CI build. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Use static import for HtmlDecorator.TYPE_NAME_LABELAlexander Kriegisch2021-03-162-25/+27
| | | | | | Mini refactoring, making the code a bit less verbose Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Fix 'ajdoc' tests for Java 15 buildAlexander Kriegisch2021-03-144-101/+111
| | | | Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
* Fix incorrect HTML entities in javadoc commentsJerry James2020-09-141-2/+2
|
* Remove unnecessary interface modifiersLars Grefer2020-08-171-15/+15
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Merge branch 'master' into feature/collection-performanceAndy Clement2020-08-154-7/+0
|\
| * Cleanup unused importsLars Grefer2020-08-165-8/+0
| | | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Weaken Collection declarationsLars Grefer2020-08-153-3/+4
| | | | | | | | | | | | Reports on declarations of Collection variables made by using the collection class as the type, rather than an appropriate interface. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Collection.toArray() call styleLars Grefer2020-08-151-1/+1
| | | | | | | | | | | | | | There are two styles to convert a collection to an array: either using a pre-sized array (like c.toArray(new String[c.size()])) or using an empty array (like c.toArray(new String[0]). In older Java versions using pre-sized array was recommended, as the reflection call which is necessary to create an array of proper size was quite slow. However since late updates of OpenJDK 6 this call was intrinsified, making the performance of the empty array version the same and sometimes even better, compared to the pre-sized version. Also passing pre-sized array is dangerous for a concurrent or synchronized collection as a data race is possible between the size and toArray call which may result in extra nulls at the end of the array, if the collection was concurrently shrunk during the operation. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Manual array copyLars Grefer2020-08-151-9/+3
| | | | | | | | | | | | Reports the manual copying of array contents which may be replaced by calls to System.arraycopy(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* | Manual array to collection copyLars Grefer2020-08-151-11/+2
|/ | | | | | Reports the copying of array contents to a collection where each element is added individually using a for loop. Such constructs may be replaced by a call to Collection.addAll(Arrays.asList()) or Collections.addAll(). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Merge branch 'master' of github.com:eclipse/org.aspectj into ↵Lars Grefer2020-08-142-89/+4
|\ | | | | | | remove-old-version-checks
| * Merge branch 'feature/simplify-ajdoc' of github.com:larsgrefer/org.aspectj ↵Lars Grefer2020-08-142-91/+4
| |\ | | | | | | | | | | | | | | | into feature/github-actions Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| | * Always run javadoc using the ToolProvider APILars Grefer2020-08-142-87/+4
| | | | | | | | | | | | | | | | | | `com.sun.tools.javadoc.Main` isn't available in recent Java versions (13+) Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
| * | Fix compilation of JavadocRunner for Java 13+Lars Grefer2020-08-131-5/+7
| |/ | | | | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* / Simplify checks for Java 8 to trueLars Grefer2020-08-142-123/+37
|/ | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Use the diamond operator where possibleLars Grefer2020-08-134-22/+22
| | | | Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* 'String.indexOf()' expression is replaceable with 'contains()'Lars Grefer2020-08-083-24/+24
| | | | | | Reports any String.indexOf() expressions which can be replaced with a call to the String.contains() method available in Java 5 and newer. Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* 'for' loop replaceable with enhanced 'for' loopLars Grefer2020-08-086-56/+47
| | | | | | Reports for loops which iterate over collections or arrays, and can be replaced with an enhanced for loop (i.e. the foreach iteration syntax). Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>
* Java 13 supportAndy Clement2019-11-252-148/+172
|
* Updated with Java12 supportAndy Clement2019-04-034-37/+55
|
* Fix version tagging for info stringsAndy Clement2019-02-112-2/+2
|
* Add module tests back in - but streamlinedAndy Clement2019-01-313-48/+36
|
* mavenizing ajdoc - doneAndy Clement2019-01-306-54/+27
|
* mavenizing ajdoc - wipAndy Clement2019-01-2924-0/+2919
|
* Support Java10Andy Clement2018-04-182-22/+49
|
* Updates to better cope with future JDKsAndy Clement2017-11-094-61/+66
| | | | | | | | | | | | | | The version handling in LangUtil has been overhauled to cope better with post 1.8 releases (JDK9 and JDK10 or 18.3 or whatever they call it). As part of this moved to treating JDK9 as '9' rather than '1.9'. Also removed duplicate version processing logic and had that defer to the one place in LangUtil where we now deal with it. Includes some generics tidyup in ajdoc. More ajdoc work is necessary for Java10 because it removes the standard doclet (old style). However trying to invoke the internal Javadoc handler in Java10 is failing due to module visibility rules.
* 464604: ajdoc SIOOBE on Java7Andy Clement2015-09-041-0/+5
|
* Fix 436653: conditional aspect activation plus various polishAndy Clement2014-10-061-1/+27
| | | | | | | | | | | | | | Modified test expectation system so it is possible to say the test cares about one particular message and the rest do not matter (prefix message string with '*') - crude but quick. Polished many places to exploit generics Upgraded all the tests to work on Java8 - some serious changes regarding ajdoc on Java8. Hopefully it has stayed backwards compatible with earlier JDK versions (e.g. if using AspectJ 1.8.3+ with a JDK less than 8) but no explicit testing done for this.
* add apt testshsestupin2014-08-011-1/+1
| | | | Signed-off-by: hsestupin <stupin.sergey@gmail.com>
* minimalModel ON by default. demotion ON by default (for AJDT as well as LTW)aclement2011-08-051-1/+1
|
* 280783: removed security manager - why is it there?aclement2009-06-181-51/+50
|
* 258206: package declaration support in the modelaclement2009-01-061-1/+3
|
* attempt to commit patch for 256514 again: fixed the patch to be non-windoze onlyaclement2008-12-152-0/+60
|
* backed out changes - break the buildaclement2008-12-082-59/+0
|
* 256514: c1aclement2008-11-272-0/+59
|
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-08 19:24:37 +0000