diff options
author | James Moger <james.moger@gmail.com> | 2014-11-20 08:12:31 -0500 |
---|---|---|
committer | James Moger <james.moger@gmail.com> | 2014-11-20 08:12:31 -0500 |
commit | 4f91e35621929e1ebcebcd58bdaa3d858302df74 (patch) | |
tree | 667eb3e69eeeeb27a5645f9d8b2834589d029860 | |
parent | 8f1dc607d135fd99d769a2dfd1e11e00d72d0506 (diff) | |
parent | add899d48daaec9b4df1a0fdcbdd5fc6cce0da0b (diff) | |
download | gitblit-4f91e35621929e1ebcebcd58bdaa3d858302df74.tar.gz gitblit-4f91e35621929e1ebcebcd58bdaa3d858302df74.zip |
Merge pull request #232 from tomaswolf/ticket-88-bugfix
Usability bug fix
-rw-r--r-- | src/main/java/com/gitblit/wicket/pages/scripts/imgdiff.js | 22 |
1 files changed, 20 insertions, 2 deletions
diff --git a/src/main/java/com/gitblit/wicket/pages/scripts/imgdiff.js b/src/main/java/com/gitblit/wicket/pages/scripts/imgdiff.js index e993997a..61575132 100644 --- a/src/main/java/com/gitblit/wicket/pages/scripts/imgdiff.js +++ b/src/main/java/com/gitblit/wicket/pages/scripts/imgdiff.js @@ -167,9 +167,27 @@ function setup() { overlayAccess.moveAuto(newRatio); } }); + + var autoShowing = false; $opacitySlider.on('slider:pos', function(e, data) { - if ($div.width() <= 0 && !blinking) overlayAccess.moveAuto(1.0); // Make old image visible in a nice way - $img.css('opacity', 1.0 - data.ratio); + if ($div.width() <= 0 && !blinking) { + // Make old image visible in a nice way, *then* adjust opacity + autoShowing = true; + overlayAccess.moveAuto(1.0, 500, function() { + $img.stop().animate( + {opacity: 1.0 - opacityAccess.getRatio()}, + {duration: 400, + complete: function () { + // In case the opacity handle was moved while we were trying to catch up + $img.css('opacity', 1.0 - opacityAccess.getRatio()); + autoShowing = false; + } + } + ); + }); + } else if (!autoShowing) { + $img.css('opacity', 1.0 - data.ratio); + } }); $opacitySlider.on('click', function(e) { var newRatio = (e.pageX - $opacitySlider.offset().left) / $opacitySlider.innerWidth(); |