summaryrefslogtreecommitdiffstats
path: root/src/main/java/com/gitblit/wicket/RequiresAdminRole.java
diff options
context:
space:
mode:
authorFlorian Zschocke <f.zschocke+git@gmail.com>2021-10-24 17:55:36 +0200
committerFlorian Zschocke <f.zschocke+git@gmail.com>2021-10-24 17:55:36 +0200
commitf1b150b8f3860e9116ecc7a5290e8296ca4fdcb5 (patch)
treec74ee7059c87e9f52bc3f4838c2221c50642b965 /src/main/java/com/gitblit/wicket/RequiresAdminRole.java
parent583e15eb3f0f3a565b031dc554b420e28c50baae (diff)
downloadgitblit-f1b150b8f3860e9116ecc7a5290e8296ca4fdcb5.tar.gz
gitblit-f1b150b8f3860e9116ecc7a5290e8296ca4fdcb5.zip
raw: URL encode the links to raw view of files
So far links to raw view were not encoded. The browser did some encoding of spaces on its own, which the servlet would unescape, since it uses the `HttpServletRequest.getPathInfo` method. That decodes the path before returning it. A problem arises when a bracket is in the file (or folder) name. The brackets are the characters that are not allowed in the path, according to the `URI.parse` method. (Which is a bit harsh, because brackets actually are only reserved for the host part since IPv6.) That means that the decoding fails when a bracket character is encountered. This went unnoticed since the failed decoding will return the path as it got it. But once there is a space in the file name, which the browser helpfully encoded for us, the failed decoding will now leave the encoded space in there. And that will result in a path that does not exist, e.g. `file%20[a]`. To be on the safe side, we simply encode the path in the links that we generate, so that it complies with the rules that are used in `getPathInfo`. This fixes #1375.
Diffstat (limited to 'src/main/java/com/gitblit/wicket/RequiresAdminRole.java')
0 files changed, 0 insertions, 0 deletions