summaryrefslogtreecommitdiffstats
path: root/src/main/java/com/gitblit/wicket
Commit message (Collapse)AuthorAgeFilesLines
* Update Git clients list on empty repository pageFlorian Zschocke2023-10-1214-24/+24
| | | | | | | | | | | | The page shown for an empty repository lists suggestions for Git clients, mostly GUI ones, and links to their web pages. The TortoiseGit client entry is removed since the URL is no longer valid. The excellent client Fork is added to the closed source clients section. This commit also cleans up some other entries, fixing broken tags, escaping ampersands and removing outdated or wrong information.
* Improve Chinese translation of "fork"Florian Zschocke2023-10-091-17/+17
| | | | | | | The currently used translation of "fork" is ambiguous, using the same word as for "branch". Fixes #1448
* fix: Fix incorrect text being copied by copy button on tickets pageFlorian Zschocke2022-12-061-1/+1
| | | | The merge step for using `pt` added the wrong text to the copy button.
* Add french version of Empty Repository pageFlorian Zschocke2022-12-051-0/+60
| | | | Donated by @piradix
* fix: Fix broken _de language fileFlorian Zschocke2022-12-051-2/+2
| | | | | This fixes incorrect encodings in the _de language file which makes the pages crash.
* fix: Correct misaligned images in primary repository URL displayFlorian Zschocke2022-12-051-2/+2
| | | | | | Adding style element `max-width:inherit` as suggested by @piradix, which makes the access restriction icon be part of the URL box again. This fixes #1437
* Replace SWF clippy with clipboard.js on ticket pageFlorian Zschocke2022-12-032-19/+12
| | | | | The ticket page also has some copy-to-clipboard buttons, which get updated to work with JS instead of SWF.
* Add a "Copied" tooltip to the copy-to-clipboard buttonFlorian Zschocke2022-12-033-11/+11
| | | | | | | This is not the ideal version, since the height is too low for the tooltip used for the drop-down menus. Probably has something to do with the container or something. But at least something is there now, even if not the most beautiful.
* Replace SWF clippy with clipboardjs on repository pageFlorian Zschocke2022-11-203-25/+28
| | | | | | | | | | | | | | | Shockwave Flash is dead. But Gitblit still uses it to copy the repository URLs to the clip board. Which doesn't work anymore since no browser uses Flash anymore, so this has degraded disgracefully. Instead, we can use JavaScript to copy directly to the clipboard, now that there are APIs for it. So replace the use of clippy.swf on the repository page with clipboard.js[1]. This right now only has the functionality to copy to clipboard but now visual feedback, yet. This addresses GH issue #1241. [1] https://clipboardjs.com
* Fix issue with not serialisable ed25519 SSH keysFlorian Zschocke2022-11-161-1/+23
| | | | | | | | | Adding Ed25519 keys brings the problem that with the library currently used, the PublicKey instance of that key is not serialisable. This results in an exception when wicket tries to cache the UsersPage. So change the SshKeysPanel so that the PublicKey object is removed from the `SshKey` when the panel is detached. It can be regenerated from the raw key data.
* Replace key feedback with label instead of FeedbackMessageFlorian Zschocke2022-11-013-6/+18
| | | | | | Since it is a pest to get rid of a Wicket FeedbackMessage in an AJAX target, change the code to use an extra label that can provide feedback if the key could not be parsed or was empty.
* Add feedback to SSH Key Form. #1226Martin Spielmann2022-11-014-1/+9
| | | | | if key is empty of can not be parsed, form did provide any feedback to user before
* pages: Fix link for GitExtension, which moved to GithubFlorian Zschocke2022-04-0913-13/+13
|
* Update japanese translationTakehide Morimoto2022-01-153-170/+1260
|
* pages: Fix repo-relative reference links in markdown docsFlorian Zschocke2021-12-061-14/+39
| | | | | | | | As with explicit links, also for reference links in markdown documents which point to repository-relative files the links are broken. They do not take the path to the repository into account. This fix is related to commit b23269 which fixed issue #1358 for explicit links.
* bug: Fix double encoding links in Markdown/Wiki pagesFlorian Zschocke2021-12-041-5/+0
| | | | | | | | | | | | | When parsing Markdown or Wiki pages, links get URL encoded. This happened twice for links to other documents. Once explicitly and once by Wicket when it creates a `urlFor` the page. That results in multi-byte characters getting percent escaped, and then the percent character again getting percent escaped. The explicit encoding looks like a forgotten left over, so it gets removed from the code. The Wicket encoding is smarter anyways, knowing what is path and what is parameter. This fixes #864.
* Fixes external links broken in markdown rendering (#1392)TomaszSzt2021-11-181-0/+16
| | | | | * This commit fixes what was broken in commit https://github.com/gitblit/gitblit/commit/b23269acc0f460f583311c679d751925b8402563 due to #1358 issue
* Issue #1011: do not serialize JGit commit objectsTom2021-11-0311-69/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | JGit commit objects are a recursive data structure; they have links to their parent commits. Serializing a JGit commit will try to recursively serialize all reachable ancestors as faras they have been loaded. If that ancestor chain is too long, a StackOverflowError is thrown during Wicket's page serialization if a page has a reference to sucha JGit commit. Fixed by making sure that pages o not contain references to JGit commits. Use the (existing) wrapper object RepositoryCommit instead. * RepositoryCommit has a transient reference to the JGit commit and reads the commit from the repository upon de-serialization. * RefModel is a similar case (JGit tags/branches may also have links to the commits they point to). Solved a bit differently by making it a pure data object by transferring the interesting data from the JGit object in the constructor. * Change DataViews instantiated with RevCommit to use RepositoryCommit instead. * Change inner anonymous DataViews to ensure they do not have a synthesized field referencing the "allRefs" map. Such a synthesized field would also get serialized, and then serialize JGit commits again. Finally, remove non-transient logger instances in Wicket classes. Those might lead to NotSerializableException. These StackOverflowErrors have been reported in several places since 2014: * https://groups.google.com/forum/#!topic/gitblit/GH1d8WSlR6Q * https://bugs.chromium.org/p/gerrit/issues/detail?id=3316 * https://groups.google.com/d/msg/repo-discuss/Kcl0JIGNiGk/0DjH4mO8hA8J * https://groups.google.com/d/msg/repo-discuss/0_P6A3fjTec/2kcpVPIUAQAJ * https://github.com/gitblit/gitblit/issues/1011 * https://github.com/tomaswolf/gerrit-gitblit-plugin/issues/21
* Add test for loading russian propertiesFlorian Zschocke2021-11-031-0/+3
|
* Adding Russian Translate Добавлен русский языкVladimir A2021-11-033-0/+848
|
* Property bundle: Fix typo in "nl" language fileFlorian Zschocke2021-10-211-1/+1
|
* Property bundle: Fix various errors with escapesFlorian Zschocke2021-10-213-21/+21
| | | | | Double escaped backslashes, wrongly escaped unicode codes, broken escaped newlines.
* Property bundle: Fix incorrect property keysFlorian Zschocke2021-10-218-12/+10
| | | | | | | Some property keys had typos. There is a `gb.ticketStatus` and a `gb.ticketState`. Neither is used anywhere in the code, but only the former is defined in the default file. So only use `gb.ticketStatus`.
* Escape non-ASCII characters in the GitBlitWebApp_pt_BR.properties fileFlorian Zschocke2021-10-211-220/+219
| | | | If keeps acting up when trying to stage parts of it. I hope this fixes that.
* fix: Remove trailing spaces from property bundle filesFlorian Zschocke2021-10-2114-83/+83
|
* fix: Remove duplicate property keys from properties filesFlorian Zschocke2021-10-2114-27/+12
| | | | | | | | | | Some property keys were duplicated, mostly `status`, `permission` and `comment`. The problem with `gb.comment` is, that it is used in two different locations in two different meanings. One as a verb, the second as a noun. Which makes no difference in English, but other languages. The solution is that the second key is renamed to `gb.sshKeyComment`. The code is adjusted accordingly.
* Add a unit test to check if the resource bundle can be loadedFlorian Zschocke2021-10-2014-6/+50
| | | | | | | | | To prevent that we have a resource file in a resource bundle broken and not loading undiscovered for years, add a unit test that will load the resource properties file for each of the languages. In order to check if the file was loaded and the bundle mechanism didn't fall back on the default, a new property key is added to each language file, solely for the purpose to be checked in the unit test.
* Fix a wrong unicode escape in the Norsk language properties fileFlorian Zschocke2021-10-201-1/+1
| | | | This fixes #834
* Update zh_CN translationYMNNs2021-05-031-269/+310
| | | Updated simplified Chinese translation and added missing entries. This translation is now 100% completed.
* fix: Also parse exp links in MD pagesFlorian Zschocke2020-11-161-0/+8
| | | | | | Add a link parser also for `ExpLinks` because we need to escape paths to files in subfolders. This closes #1358
* Fix user preferences selecting the wrong preferred locale.Florian Zschocke2019-11-112-46/+28
| | | | | | | | | | | Due to a wrong comparison, when loading the preferred locale in the user preferences page, in cases like `zh_CN` or `de_DE` the wrong locale would be chosen. As with too many things, the code is duplicated on the `UserPage` and the `EditUserPage`. And they differ. So extract the choosing of the preferred language for display into a method in the (more up-to-date) `UserPage` and call that from the `EditUserPage`.
* Guard docs pages against bad URLsFlorian Zschocke2019-11-112-0/+9
| | | | | | | | If, for example, an external site links to a docs page or a specific doc page, and the branch that link points to is no longer existing, an internal error happens due to a NPE. The NPE is guarded against and a No Docs page is returned.
* Merge branch 'pingunaut-1166_more_secure_password_hashes' into master.Florian Zschocke2019-11-062-25/+16
|\
| * Use the new PasswordHash classes.Florian Zschocke2019-11-052-29/+16
| | | | | | | | | | | | Integrate the `PasswordHash` class and subclass in the user and password editing and authentication. Replaces the old code and the previous `SecurePasswordHashingUtils` class.
| * Replaced duplicated strings by using constantMartin Spielmann2017-01-071-2/+2
| |
| * Added possibility to use secure hashes to store passwordsMartin Spielmann2017-01-011-1/+5
| | | | | | | | Addresses #1166
* | Remove "folding outlines" and sort repositories before subfolders.Florian Zschocke2019-06-152-19/+21
| | | | | | | | | | | | | | | | Remove guard rails at the left to get a cleaner look. To make it easier to determine which repositories belong to which folder, display the repositories first, then the subfolder. Decreased indentation a little.
* | Add support nested groups on the Repositories pageFlorian Zschocke2019-06-154-5/+368
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix for #725. Also covers #527. This is a squashed commit of the following commits, merging and closing pull request #1267: commit 55fee41769ffab1aff59344fe117d481687aa743 Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 17:19:53 2017 +0100 declared local variable final to fix travis build commit 131e4d14a48c2a3fdce621fa54637de50684d040 Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 14:11:55 2017 +0100 fix formatting (use tab for identation) commit 8da5f6d5967894f157251c320928acdab3a451e7 Author: Martin Spielmann <mail@martinspielmann.de> Date: Mon Nov 6 13:45:39 2017 +0100 Add repositoryListType tree. Addresses #725, 527 and includes #1224 commit 6c061651fb95212ae242dbca06c8d9ef80146201 Merge: f365daa3 40ee9653 Author: Martin Spielmann <mail@martinspielmann.de> Date: Sat Nov 4 13:19:08 2017 +0100 Merge remote-tracking branch 'collapsible/ticket/527' into 725_nested_repos commit f365daa3b1d6be135365f9b11bdece320beabf4e Author: Martin Spielmann <mail@martinspielmann.de> Date: Sat Nov 4 13:10:24 2017 +0100 first working version of tree model
* | collapsible group repositoriesybosy2019-06-153-3/+60
| |
* | Null-safe compare for ticket milestones without due dateFritz Schrogl2019-06-101-2/+14
| |
* | Update link target to Lucene 5.5 query syntax, moving the link to the page.Florian Zschocke2017-03-0516-119/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the link target to the query parser syntax page of the 5.5 version. Refactor the `LuceneSearchPage` to use an `ExternalLink` for the link to the lucene page, so that the link target is kept and updated in the Java code. Move the link out of the language files. This was way too cumbersome to update the link target (which is probably why no one ever did). The query help text is changed to contain a variable: `gb.queryHelp = here be some ${querySyntax} help`, which is replaced by Wicket with a link. The link text is a new lange file property: `gb.querySyntax`.
* | Better Czech localizationJan Breuer2017-03-031-76/+76
| |
* | Add Czech localeJan Breuer2017-02-153-0/+848
| |
* | New Setting "Default Language" when creating user.william2017-02-084-29/+71
| |
* | Sending email (certificate zip file) based on locale that user selectedwilliam2017-01-242-0/+2
| |
* | Update korean translation for gitblit new version.DONGSU, KIM2017-01-051-718/+759
|/
* Merge pull request #1160 from fzs/sshLdapAuthenticatorFlorian Zschocke2016-12-181-0/+9
|\ | | | | LDAP SSH key manager
| * The public key manager can disable writing keys, which hides commandsFlorian Zschocke2016-12-061-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some public key mangers may be read-only, i.e. not allow to add or delete keys, or to change the key comment or assigned permissions. In such a case the respective commands should not be available on the SSH shell and the SSH Keys panel should also not offer the possibility. The `IPublicKeyManager` gets three new methods, modelled after the `AuthenticationManager`: `supportsWritingKeys`, `supportsCommentChanges` and `supportsPermissionChanges`. They return true if a key manager allows for keys to be written or updated. For example the existing `FileKeyManager` will return true for all three since it allows to store and update keys in a file. The new `LdapKeyManager` returns false since it only accesses LDAP and can not add or update any keys in the directory. A future key manager might get keys from an LDAP directory but still keep comments and permissions for it in a local copy. If writing of keys is not supported: * the welcome shell does not suggest adding a key, * the `SshKeysDispatcher` does not offer the "add", "remove", "comment" and "permission" commands, and * the SSH keys panel hides the "delete" button in the key list, and the "Add Key" form. The hiding of the "Add key" form is not perfect since the surrounding div is still shown, but I don't know how to hide it and it didn't look too bad, either.
* | Merge branch 'rcaa-master' into master.Florian Zschocke2016-12-131-1/+1
|\ \
| * | removing duplicated code for cookie genaration and adding random bytes to ↵Rodrigo Andrade2016-08-151-1/+1
| | | | | | | | | | | | generate user cookies